-
-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instances #6237
base: main
Are you sure you want to change the base?
Add instances #6237
Conversation
93a8e75
to
1c20a74
Compare
I need this |
Everybody needs this))) |
YES ! Get this merged asap ! |
@SoftFever please verify and merge this. This is a must for anyone printing in batches |
Sure, open PR. So I did menu, and you buttons. Both things go well together.
|
1c20a74
to
1739bc1
Compare
1739bc1
to
11a2d26
Compare
Also resolves #2719 Re-add instancing support for objects on the print bed |
@michmela44 is it possible to disable the "autoarrange" when adding instances? It makes creating large arrays of small parts painfully slow. Auto-arrange is a call-it-when needed thing, no? |
Sure, in the slicer global options.
|
Possible bug: When you click "add instance", the button becomes unclickable for a brief but variable period of time. If you don't do anything, it goes clickable again with green highlight. But if you happen to click it again while it's unclickable, it stays unclickable until the mouse moves a pixel or two, and only then does the green highlight come back on. Is this a common behavior across UI controls here? |
Yes, there is a check whether add instance operation is currently available. Probably it could be optimized. |
Yeah the usability issue isn't that it goes unavailable so much as that it
requires mouse to move to reactivate in this weird case. I'll try to take
a look at that how that button code is working at some point, maybe there's
just some UI element state getting reset on failed mode click...
…On Mon, Aug 26, 2024, 4:31 AM Vovodroid ***@***.***> wrote:
the button becomes unclickable for a brief but variable period of time.
Yes, there is a check whether add instance operation is currently
available. Probably it could be optimized.
—
Reply to this email directly, view it on GitHub
<#6237 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGVYIPE2IVSD3NHR5DDRTZTMGY3AVCNFSM6AAAAABLMCQN2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZHE4DIMRXHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Or click on disable button. Indeed. |
Just checked and Prusaslicer doesn't appear to make this slow check call on "add instance", at least in 2.7.4. |
Actually the whole code of |
Interesting! I'll get on the latest PS and see if anything has changed/feels weird. |
Any news on this? |
It's kinda working -- instances can be created and removed, and with the
right action I have successfully replaced a group of instances with a new
part -- but copy/paste of instance groups is still broken, unfortunately,
which makes certain kinds of large-scale replication tasks very awkward.
But it's at least moving forward!
…On Wed, Sep 11, 2024 at 3:43 PM Nikolai ***@***.***> wrote:
Any news on this?
—
Reply to this email directly, view it on GitHub
<#6237 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGVYLW4E67P2VX4NHDE63ZWDBS3AVCNFSM6AAAAABLMCQN2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBUHAZTAMZZHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@vovodroid @morganvenable @SoftFever Do you guys think this feature could be ready and included with the stable release of orca v2.2? |
I think so. |
@vovodroid @SoftFever @Azio-Pantheon @morganvenable |
any chances to get this in next beta/RC? |
how can we test it? i tried to build this one but i havent environment for this, and got some errors when just fires release_build.bat is executable somewhere to get? |
It's in a dev release, I don't recall the specifics. There's still a ways
to go re dealing with arrangement of parts and copy/paste.
For the time being I've reverted to mainline, it's unfortunately difficult
to get this together piecemeal because it touches so many different parts
of workflow.
…On Fri, Oct 25, 2024, 6:33 AM Kuba Miszcz ***@***.***> wrote:
@vovodroid <https://github.com/vovodroid> @morganvenable
<https://github.com/morganvenable> @SoftFever
<https://github.com/SoftFever> Do you guys think this feature could be
ready and included with the stable release of orca v2.2?
how can we test it? i tried to build this one but i havent environment for
this, and got some errors when just fires release_build.bat
is executable somewhere to get?
—
Reply to this email directly, view it on GitHub
<#6237 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGVYJYRF5WLOQIYH7ZJTDZ5JCAZAVCNFSM6AAAAABLMCQN2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZXG44TGNZWGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
11a2d26
to
ad2d500
Compare
ad2d500
to
cbe4fa4
Compare
@KubaMiszcz I build it locally on Win10 with VS2022 and build_release_vs2022.bat. I updated PR to the latest main, try to build it again. @morganvenable actually this PR doesn't existing workflow, so if one doesn't use instances it won't harm. I only added menu and tool bar and uncommented original Prusa code. |
Yeah, I was using a random dev build instead of building myself, so I was
waaaay off track of current RC :) So... lazy...
…On Fri, Oct 25, 2024 at 8:59 AM Vovodroid ***@***.***> wrote:
@KubaMiszcz <https://github.com/KubaMiszcz> I build it locally on Win10
with VS2022 and build_release_vs2022.bat. I updated PR to the latest main,
try to build it again.
@morganvenable <https://github.com/morganvenable> actually this PR
doesn't existing workflow, so if one doesn't use instances it won't harm. I
only added menu and tool bar and uncommented original Prusa code.
—
Reply to this email directly, view it on GitHub
<#6237 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGVYMDM2QJHKHLLSEDEUDZ5JTELAVCNFSM6AAAAABLMCQN2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYGIYDAMBZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Please bring this back. This is the only reason I hate using Orca Slicer and I have no idea why Bambu removed it in the first place |
Hi, just mentioning this as proper instancing/sharing settings it is something super important, hope that it will be reviewed merged soon! |
I download the nightly build to try this feature but it hadn't that. :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MongooseTNM this naming is Prusa (actually Slic3r) inheritance, and exists in Bambu Studio, so I just use it as is. |
I have been testing this feature, and it is one that I could really benefit from. But I think it has some quirks that could be improved:
2-It seems like instances and exclude object functions aren't working well together. When I try to skip an object, not all of the objects in the buildplate are selectable. As you can see in the photo below, only 14 out of the 48 items on the plate are selectable to skip. 3-It seems like instances and "as object list" intra-layer order aren't working well together. Sometimes when I use instances and select "as object list" intra-layer order, the order of the instances is not respected, and the objects print in random order. You can see in the video below that the print order doesn't match the object list order, even though "as object list" is selected as the intralayer order. 4-when I enable instances of multicolor objects, the prime tower preview gets extremely long and takes up too much space on the buildplate, and sometimes OrcaSlicer interprets this as an object out of boundary, and I can't click slice. I have to move the prime tower preview around, seemingly at random, until the "slice plate" button becomes active again. I would also like to propose a few enhancements: 1-Allow for rotation of all the instances in place. I found a workaround for this. I add a surface with zero volume as a part, and then I can rotate the main body or main parts, and it propagates to all instances. 2-Allow for rearrangement of the order of the instances. This can be useful when I choose "as object list" as the intra-layer order. This way I have the freedom to arrange all the objects on the buildplate without paying attention to their order in the object list and later rearrange their order in the object list. I would like to be able to rearrange instances as I can rearrange individual objects, as shown in the video below. 3-Allow to duplicate or copy/paste an object with its instances and keep the relative position of all the instances. This can be really useful when I have several variants of a model and I want to print them all in batches. I can load and arrange the first variant, and then I can copy and paste that arrangement to a new buildplate and just load the new variant, and it will already be arranged in the same way as the first one but in a new buildplate. This way I can create a single project with batches of all the variants in different buildplates. You can see in the video below that when I copy and paste a set of instances, they get all centered, losing the original arrangement: I wish I knew how to code to help in the development and improvement of this feature, but I don't. So all I can do is test it and report my observations, and hopefully the developers will work on it. |
Resolves #632 [FR] Convert from "Cloning" models to "Instances" like PS originally does. , resolves #545 Fill Bed With Instances, resolves #448 [Feature Request]: Add / Remove instances of item like prusa slicer.
For whatever reasons Bamboo dropped instances support. Fortunately they only commented out some code (besides menu creation, I restored it from Prusa), while keeping all instances infrastructures.
Besides usability instances speed up slicing.
Resolves #632 Resolves #2719