Dark mode fixes

[jamincollins]

Description

This fixes issues with the print settings tabs on both Linux and Mac.

Screenshots/Recordings/Graphs

Before:

After:

Tests

Built and tested on both (Arch) Linux and Mac.

[jamincollins]

The last lines of the failed workflow action look like a successful build to me:

ld: warning: direct access in function '___cxx_global_var_init.4' from file '/Users/runner/work/OrcaSlicer/OrcaSlicer/deps/build_x86_64/OrcaSlicer_dep_x86_64/usr/local/lib/libboost_thread.a(thread.cpp.o)' to global weak symbol 'boost::exception_detail::exception_ptr_static_exception_objectboost::exception_detail::bad_exception_::e' from file 'src/libslic3r/liblibslic3r.a(utils.cpp.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
ld: warning: direct access in function '___cxx_global_var_init.4' from file '/Users/runner/work/OrcaSlicer/OrcaSlicer/deps/build_x86_64/OrcaSlicer_dep_x86_64/usr/local/lib/libboost_thread.a(thread.cpp.o)' to global weak symbol 'guard variable for boost::exception_detail::exception_ptr_static_exception_objectboost::exception_detail::bad_exception_::e' from file 'src/libslic3r/liblibslic3r.a(utils.cpp.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
Verify localization with gettext...
./run_gettext.sh: working dir = /Users/runner/work/OrcaSlicer/OrcaSlicer
Fix macOS app package...

I don't see a way to re-run it myself.

[discip]

Finally!

Thank you so much! 🤝 😃👍 🎉

[discip]

I'm just wondering if we even need this #if here, since every operating system is affected.
Or are there more OS'es than Linux, Windows & Mac? 😊 🤷‍♂️

[jamincollins]

I agree that it probably isn't needed. And I'm happy to remove it if desired.

[discip]

I suggest to let @SoftFever have a look. 😊

[discip]

Unfortunately there is more:

#3417

[jamincollins]

Unfortunately there is more:

I'm aware there are more, that is why this commit message specifically only mentions the tabs.

I'm still tracking down the other areas.

[jamincollins]

These are the areas I've identified as needing to be fixed:

• Print settings
• Rename plate
• Export Configs
• Network Test (output)
• Unsaved Changes
  • UnsavedChangesDialog.cpp
• "Send G-Code to printer host"

I'll add to the list as I find them and fix them.

[discip]

that is why this commit message specifically only mentions the tabs.

Oh, sorry, was not aware of that. 🤦🏻

I'll add to the list as I find them and fix them.

Great views! 👍

[yw4z]

3882
3667
this 2 might be related

[jamincollins]

3882 3667 this 2 might be related

I'll make sure these are on my list of areas to dig into

[discip]

@jamincollins

• Print settings

• Rename plate

• Export Configs

• Network Test (output)

• Unsaved Changes

  • UnsavedChangesDialog.cpp

• "Send G-Code to printer host"

Maybe you could put these into the initial post, so the progress can be monitored easier. 😊

[jamincollins]

I'd rather get the fixes committed and merged as completed than wait for all to be found. I don't mind having a main tracking ticket, but it may take me some time to get to all of them.

[jamincollins]

I've added several more fixes for light/dark mode issues:

Custom G-Code Editor

Before:

After:

Export Configs

Before:

After:

Network Test

Before:

After:

Printer settings

Before:

After:

Rename Plate

Before:

After:

Send G-Code

Before:

After:

Unsaved Changes

Before:

After:

[discip]

@jamincollins
But the actual g-code (2nd screenshot) is still black. Maybe you could fix that as well.

[jamincollins]

Yes, trying to track it down. But it is better than before. And additions to it are white.

[discip]

But it is better than before.

Definitely!

[jamincollins]

Closing this PR in favor of a slightly different (and IMO better) approach.