Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Better Scrolling Over Multiline Fields #4218

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

Ocraftyone
Copy link
Contributor

While scrolling over multiline option fields, the mouse scrolling is ignored and sent to the parent window. Scroll is transfered back to the field if it is in focus and is able to scroll.

@SoftFever
Copy link
Owner

Looks like I can't scroll the multi-line box anymore

scroll.mp4

@Ocraftyone
Copy link
Contributor Author

Hmm. It should take over once it gets focus. Let me test RQ

@Ocraftyone
Copy link
Contributor Author

@SoftFever I was a dumb dumb and used a function based on name rather than documentation 😆. Found a different way to determine if the control can scroll.

@SoftFever
Copy link
Owner

@SoftFever I was a dumb dumb and used a function based on name rather than documentation 😆. Found a different way to determine if the control can scroll.

It works now.
I like how it scrolls now, thank you 👍

@SoftFever SoftFever merged commit 047b889 into SoftFever:main Feb 27, 2024
12 checks passed
@Ocraftyone
Copy link
Contributor Author

This has been bugging me since I started printing using prusa slicer. I can finally enjoy scrolling my custom gcode 😄

@Ocraftyone Ocraftyone deleted the enh-gcode-edit-scrolling branch March 30, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants