-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seam: use scarf joint to minimize seam visiblity #3839
Conversation
I'll post a few comparasions later. Meanwhile, feel free to test for yourself once the CI build is completed: slop_test.zip |
oh wow, the result is truly amazing! |
Alright this is really interesting. To get it to work properly (I think?) I had to make some extra changes - disabling wipe on loops and external loops, and also set the seam gap to 0. Left the slope settings default. Settings in image - (printed in PETG, so its stupid hard to take a proper pic its so shiny) Top - enable sloped seam, disable wipe on loops, disable wipe on external loops, seam gap 0 Love to see innovation like this and the flow compensation stuff. |
thanks in advance |
The tooltip should say that the perimeter to be optimised needs to be printed first. Usually that would be the external perimeter, but something else where the bore of a tube is to be optimised. I think that the user should be given a choice of how long the scarf should be, with an entire perimeter being the longer extreme. (2. Yes, I think my scarf seam suggestion was first, but vgdh's seems to have come up with the idea independently.) |
There is a "Slope length" option that do this, but slightly differently. Currently it applys the slope on perimeters that longer than this value, and do the normal seam otherwise. I think I'll update that so it uses the perimeter length as the limit instead as you described.
I agree that you posted this idea on PS' github first, though here is the thing, I didn't know that until someone raised #3408, and at that time I've already played around with #3211 for a while, including that post-process script, that's why I called this feature "sloped seam". I hope you understand that I didn't mean to intentionally ignore your contributions. And thanks for what you've done to the community! |
I never thought that anyone was intentionally ignoring my post, and don't really care much, as long as the feature is available. Nonetheless, I do think that 'scarf seam' is a better name than 'sloped seam' for two reasons. First, scarf seams are well known to the large woodworking community and that name does not require a neologism. Second, 'sloped seam' would apply equally well to a sloping (i.e. non-vertical) arrangement of conventional end to end seams on a part. Users of the slicer will need to learn that 'sloped seam' refers to a particular usage of a common word, which is a less simple task than using a standard technical term, even where that term might be new to the user. |
Look how wonderful things are brewing up in this community! Call for more testing results/photos so that @Noisyfox can refine the parameters further! 👍 |
I see. I just googled it and seems it's called scarf joint (because when I googled "scarf seam" I literally got a whole page of scarf)? Maybe let's call this option scarf joint then? |
Scarf joint seam works for me. |
Just to clearify, seam gap should not matter when this is enabled, as I've already disabled the seam gap for external perimeter when scarf is used. If seam gap does make a difference in your test, then that's a bug and needs to be fixed. |
I realized after looking carefully at the sliced preview and changing the setting back and forth that that is the case. It is working as you intended. I'm just running a few more test circles to see what effect some of the other settings actually have on the print. I changed everything all at once to in the first test, not very scientific. |
Try to use the latest 1033 build https://github.com/SoftFever/OrcaSlicer/actions/runs/8096108803?pr=3839 |
I got it to work with the command xattr -dr com.apple.quarantine /Applications/OrcaSlicer.app I am going to use the newest one though. |
Huge thanks to @Noisyfox for the fantastic work A big shoutout to @vgdh and @MichaelJLew for coming up with this brilliant idea and the early-stage prototype. And, of course, a heartfelt thank you to everyone who participated in the testing and discussion, with a special mention to @psiberfunk for those incredible scientific experiments. This PR has been merged. The feature will be available in the nightly build as soon as the CI/CD pipeline completes the build. Cheers to all! |
I’ll update the printables post later today so people get less confused |
@psiberfunk I remember you encountered this issue too. |
I think the solution was wider wall widths but I may remember wrongly - theory is you’ve got more flow to play with while tapering |
Yeah, makes sense. |
It’s a complex interplay of many factors @SoftFever . Are you using the optimized settings from my printables posting ? If not, start there ! |
@psiberfunk, I'm guessing you are the guy behind the Pintables post and the excel sheet v2 right ? I made a multi material print that clips together (https://thangs.com/designer/BigBricks/post/Stormtrooper%20%2ANEW%20RELEASE%2A-819) but I ran into issuers where the seams stick out a good millimetre and is not following the geometry of the model, but just goes strait up. Also how do I read the settings from the 3mf file you provided ?, bcs. I can see the start and end of my seams pretty well, but it has to be my fault I'm pretty sure bcs. i dont know how to read you settings or if i have to print the file and see what works best for me...
(to make it short and easy to answer) |
@SoftFever sorry but I don't see the files I have to download |
Ok, so first comment on github, please let me know if I did something wrong :-) |
Yes it should all be the same , something maybe not right with seam alignment settings ..? Try painting the seam and see what it does ideally this type of troubleshooting and comments would be done on the printables site , as its optimization and usage related rather than feature related : https://www.printables.com/model/783313-better-seams-an-orca-slicer-guide-to-using-scarf-s/comments Since this Pull request has been merged, this thread should probably be closed @Noisyfox @SoftFever . I’m happy to try and support people over on printables . Can we close/lock the thread here so it doesn’t become a black hole ? Unfortunately the comment history feature in GitHub is not a great place to discuss this type of thing because it’s very difficult to search, and we will keep getting off topic with respect to R&D vs support requests . |
New thread on this topic could be : #4317 with the new option Conditional Scraf Joint ? |
That’s probably the right place to discuss logic and testing and R&D, but probably not a great forum for support /help discussions . |
I added a discussion for scarf joint seams in General: Scarf joint seams |
This comment was marked as off-topic.
This comment was marked as off-topic.
You’ll need to experiment with tuning. See the printables post for tips |
Try to use 0.1 start height. |
So i tried the scarf seam. I am not sure I prefere it or not. It certainly is not as visible from a greater distance but there seams to be some over and underextrusion. I did think it coult be pressure advance, but to be honest I did some pa calibrations tests and refined it a bit but not much. Any suggestions how to work aroung these inconsistencies? |
Dose it work in Bambu? |
Implements #3211 by @vgdh directly in the slicer.
And similar idea from prusa3d/PrusaSlicer#11621 by @MichaelJLew
Todos: