Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Corrected monotonic lines not respecting user infill / wall overlap setting #3388

Conversation

igiannakas
Copy link
Contributor

@igiannakas igiannakas commented Dec 31, 2023

Removed inherited setting from BBS where the monotonic line infill and top pattern did not respect the user set infill/wall overlap setting.

This can result in tiny holes on top surfaces if flow and PA are calibrated correctly. Now the infill pattern respects the user setting similarly to all other patterns.

User can achieve the same result as before by setting the infill/wall overlap to 0 (which was the one used by BBS and overriding the user setting).

Addressing issue #2827
63E0DCDB-A62F-4521-89BC-165FA7883159_1_102_o

After:

IMG_2771

IMG_2772

perfect overlap with no holes

@igiannakas igiannakas changed the title Bug: Correct monotonic lines not respecting user infill / wall overlap setting Bug: Corrected monotonic lines not respecting user infill / wall overlap setting Dec 31, 2023
@ShryuKt
Copy link

ShryuKt commented Dec 31, 2023

This one is not a "bug", it is a feature from Bambu.
"compare to Monotonic, Monotonic linear infill has no overlap with the perimeter" from the Wiki.

Maybe if you want this behavior, it would be better to add an option instead of changing the one who exist, like SS with "line" and "lined (filled)"

@igiannakas
Copy link
Contributor Author

igiannakas commented Dec 31, 2023

Debatable but I get the point.

However the super slicer options are filled / not filled and that is purely controlling whether gap fill is applied. Superslicer always respects the overlap value as does Prusa slicer. Only bambu studio has elected to not respect that for this specific infill type, when the user can simply set it to 0 and achieve the same result. Hence why I'm raising this PR.

Another way would be when that infill is selected the overlap value is set to 0 automatically and the user notified with a popup, like what we do for vase mode. Silently ignoring the user instruction is not good UX. This way we would keep the same behaviour as default BBS but at least notify the user and give the option to override it.

@igiannakas
Copy link
Contributor Author

igiannakas commented Jan 1, 2024

After shot:

15% overlap, perfection on the top surface without any tiny holes 🎉

IMG_2772

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix.
What BL did there doesn't make sense to me either

@SoftFever SoftFever merged commit 5aae123 into SoftFever:main Jan 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants