-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Corrected monotonic lines not respecting user infill / wall overlap setting #3388
Bug: Corrected monotonic lines not respecting user infill / wall overlap setting #3388
Conversation
This one is not a "bug", it is a feature from Bambu. Maybe if you want this behavior, it would be better to add an option instead of changing the one who exist, like SS with "line" and "lined (filled)" |
Debatable but I get the point. However the super slicer options are filled / not filled and that is purely controlling whether gap fill is applied. Superslicer always respects the overlap value as does Prusa slicer. Only bambu studio has elected to not respect that for this specific infill type, when the user can simply set it to 0 and achieve the same result. Hence why I'm raising this PR. Another way would be when that infill is selected the overlap value is set to 0 automatically and the user notified with a popup, like what we do for vase mode. Silently ignoring the user instruction is not good UX. This way we would keep the same behaviour as default BBS but at least notify the user and give the option to override it. |
…-wall-overlap-values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice fix.
What BL did there doesn't make sense to me either
…-wall-overlap-values
…nes-not-respecting-infill-wall-overlap-values
…-wall-overlap-values
…-wall-overlap-values
Removed inherited setting from BBS where the monotonic line infill and top pattern did not respect the user set infill/wall overlap setting.
This can result in tiny holes on top surfaces if flow and PA are calibrated correctly. Now the infill pattern respects the user setting similarly to all other patterns.
User can achieve the same result as before by setting the infill/wall overlap to 0 (which was the one used by BBS and overriding the user setting).
Addressing issue #2827
After:
perfect overlap with no holes