Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fix & improvements to collapse sidebar #3044

Merged
merged 6 commits into from
Dec 9, 2023

Conversation

Noisyfox
Copy link
Collaborator

@Noisyfox Noisyfox commented Dec 8, 2023

image

  1. Make the collapse button smaller
  2. Fix button color in dark mode
  3. Add tooltip
  4. Fix sidebar collapse hotkey
  5. Other small bugfixes

@Noisyfox Noisyfox marked this pull request as draft December 8, 2023 15:48
@Noisyfox
Copy link
Collaborator Author

Noisyfox commented Dec 8, 2023

Just noticed a small issue. Gonna fix it tomorrow morning.

Update: false alarm, all good.

@Eldenroot
Copy link
Contributor

Please implement undo history from Prusaslicer.

@Noisyfox
Copy link
Collaborator Author

Noisyfox commented Dec 9, 2023

Please implement undo history from Prusaslicer.

Could you raise another ticket or point me to an existing one? Thanks.

@Noisyfox Noisyfox marked this pull request as ready for review December 9, 2023 02:16
@Eldenroot
Copy link
Contributor

#2425

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@SoftFever SoftFever merged commit 59164bf into SoftFever:main Dec 9, 2023
12 checks passed
@discip
Copy link
Contributor

discip commented Dec 9, 2023

@Noisyfox
Unfortunately I'm facing an issue even after this fix on Linux (Manjaro).

This is how it looks immediately after a fresh start and when switching from one setting menu to another (e.g.: Quality > Speed) or from Global > Objects.

image

image

@Noisyfox
Copy link
Collaborator Author

Noisyfox commented Dec 10, 2023

@Noisyfox Unfortunately I'm facing an issue even after this fix on Linux (Manjaro).

This is how it looks immediately after a fresh start and when switching from one setting menu to another (e.g.: Quality > Speed) or from Global > Objects.

image

image

When did this start? And which Manjaro version are you using?

@discip
Copy link
Contributor

discip commented Dec 10, 2023

It started with this #2972.

And I'm on

DISTRIB_ID="ManjaroLinux"
DISTRIB_RELEASE="23.1.0"
DISTRIB_CODENAME="Vulcan"
DISTRIB_DESCRIPTION="Manjaro Linux"

Kernel: Linux 6.3.13-2-MANJARO

@Noisyfox
Copy link
Collaborator Author

Noisyfox commented Dec 11, 2023

It started with this #2972.

And I'm on

DISTRIB_ID="ManjaroLinux"
DISTRIB_RELEASE="23.1.0"
DISTRIB_CODENAME="Vulcan"
DISTRIB_DESCRIPTION="Manjaro Linux"

Kernel: Linux 6.3.13-2-MANJARO

Which desktop env? Plasm? Xfce or Gnome? Or could you post the download link to the one you are using?

@discip
Copy link
Contributor

discip commented Dec 11, 2023

Gnome.

@Noisyfox
Copy link
Collaborator Author

It started with this #2972.

And I'm on

DISTRIB_ID="ManjaroLinux"
DISTRIB_RELEASE="23.1.0"
DISTRIB_CODENAME="Vulcan"
DISTRIB_DESCRIPTION="Manjaro Linux"

Kernel: Linux 6.3.13-2-MANJARO

Hmmmm I'm not able to find a download link to a specific version.

@discip
Copy link
Contributor

discip commented Dec 11, 2023

@Noisyfox
Copy link
Collaborator Author

Sorry, I missed your post.

Try this: https://download.manjaro.org/gnome/23.0.4/manjaro-gnome-23.0.4-231015-linux65.iso

Yeah that's what I end up downloading.

@Noisyfox
Copy link
Collaborator Author

Noisyfox commented Dec 11, 2023

image
Hmmmm it works fine on my VM. Let me do a package update then.

After upgrading everything to latest, it still works fine (though the app drawer won't open anymore)

@discip
Copy link
Contributor

discip commented Dec 11, 2023

Oh sorry, 😅
I already got totally used to the fact that I'm always getting the following message:

use system SSL certificate: /etc/ssl/certs/ca-certificates.crt
To manually specify the system certificate store, set the SSL_CERT_FILE environment variable to the correct CA and restart the
application
Do you want to continue?

Maybe this has to do something with it. 🤷🏻‍♂️

One more thing:
I'm running my 3840 x 2160 4K screen at 2048 x 1152 both (16:9).

Also the splash is only a black square. 😊
But as I said, I got used to it, as all essential parts worked.

@Noisyfox
Copy link
Collaborator Author

Oh sorry, 😅 I already got totally used to the fact that I'm always getting the following message:

use system SSL certificate: /etc/ssl/certs/ca-certificates.crt
To manually specify the system certificate store, set the SSL_CERT_FILE environment variable to the correct CA and restart the
application
Do you want to continue?

Maybe this has to do something with it. 🤷🏻‍♂️

One more thing: I'm running my 3840 x 2160 4K screen at 2048 x 1152 both (16:9).

Also the splash is only a black square. 😊 But as I said, I got used to it, as all essential parts worked.

BTW are you using the one you built yourself or use the prebuilt binary from github?

@discip
Copy link
Contributor

discip commented Dec 12, 2023

I already got totally used to the fact that I'm always getting the following message:

For some reason I forgot to mention, that this message only pops up when I start OrcaSlicer.

BTW are you using the one you built yourself or use the prebuilt binary from github?

I'm using your builds form github.

@Noisyfox
Copy link
Collaborator Author

For some reason I forgot to mention, that this message only pops up when I start OrcaSlicer.

This is normal on Linux.

I'm using your builds form github.

Have you tried the latest master build?

@discip
Copy link
Contributor

discip commented Dec 13, 2023

This is normal on Linux.

Is there anything I could do to fix this?

Have you tried the latest master build?

Will do as soon as I'm back home again.

@Noisyfox
Copy link
Collaborator Author

I'm running my 3840 x 2160 4K screen at 2048 x 1152 both (16:9).

How did you manage to do that?

@discip
Copy link
Contributor

discip commented Dec 13, 2023

How did you manage to do that?

image

@discip
Copy link
Contributor

discip commented Dec 17, 2023

@Noisyfox

It's fixed! 👍🏻

@discip
Copy link
Contributor

discip commented Dec 22, 2023

@Noisyfox
Sorry to bother you again on this but the issue I reported here #3044 (comment) is back in 0f2a223.
Maybe even earlier.

edit:
Could this be related to the fact that I'm running on another system (CPU: & GPU: AMD)?

thanks in advance

@discip
Copy link
Contributor

discip commented Dec 23, 2023

After Revert to WxWidgets 3.1.5 (#3249) this is fixed for the most part.
Currently only resizing the sidebar triggers this malfunction.

@discip
Copy link
Contributor

discip commented Jan 3, 2024

@Noisyfox

First of all, I wish you a Happy New Year! 😀

Any idea what could be causing this yet?

@Noisyfox
Copy link
Collaborator Author

Noisyfox commented Jan 3, 2024

@Noisyfox

First of all, I wish you a Happy New Year! 😀

Any idea what could be causing this yet?

No idea... I still couldn't reproduce it.

@discip
Copy link
Contributor

discip commented Jan 22, 2024

@Noisyfox
Could I somehow help solve this issue by providing additional data?

setup
OS CPU GPU RAM SSD
Manjaro x64 (Gnome) Ryzen 9 7950X3D XFX 7900 XTX G.Skill Flare X5 32 GB (EXPO I enabled) Samsung 990 Pro 2 TB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants