Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French language update #3019

Merged
merged 3 commits into from
Dec 7, 2023
Merged

French language update #3019

merged 3 commits into from
Dec 7, 2023

Conversation

bistory
Copy link
Contributor

@bistory bistory commented Dec 6, 2023

Imported FR strings from Bambustudio to keep same strings on both softwares, fixed a syntax error, added missing translations.

Everything has been check and done with Translate Toolkit.

Imported FR strings from Bambustudio to keep same strings.
Fixed a syntax error.
Added missing translations.
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

localization/i18n/fr/OrcaSlicer_fr.po Outdated Show resolved Hide resolved
Changed mention to Bambu Studio, updated name to OrcaSlicer (1 word instead of 2 like before)
@SoftFever
Copy link
Owner

@bistory First of all, thanks for the PR

Imported FR strings from Bambustudio to keep same strings on both softwares

I'd like to note that there have been numerous community updates to the French translations (and other languages, for that matter), so our aim isn't necessarily to keep the same strings. We value the community's contributions in these areas.

@bistory
Copy link
Contributor Author

bistory commented Dec 6, 2023

@bistory First of all, thanks for the PR

Imported FR strings from Bambustudio to keep same strings on both softwares

I'd like to note that there have been numerous community updates to the French translations (and other languages, for that matter), so our aim isn't necessarily to keep the same strings. We value the community's contributions in these areas.

Thanks for your reply, I agree with you because a lot of translations were done by me, however, some of the translations are not correct or are done out of the context for some partial strings. So some sentences sound weird in French... This PR should fix that and make future updates easier

Copy link
Contributor Author

@bistory bistory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed reference to BBS

@bistory bistory requested a review from SoftFever December 6, 2023 16:27
@SoftFever
Copy link
Owner

@bistory First of all, thanks for the PR

Imported FR strings from Bambustudio to keep same strings on both softwares

I'd like to note that there have been numerous community updates to the French translations (and other languages, for that matter), so our aim isn't necessarily to keep the same strings. We value the community's contributions in these areas.

Thanks for your reply, I agree with you because a lot of translations were done by me, however, some of the translations are not correct or are done out of the context for some partial strings. So some sentences sound weird in French... This PR should fix that and make future updates easier

Great!

@SoftFever SoftFever merged commit 3d2ab8e into SoftFever:main Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants