Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOL: Dev 1.9 - Regroup Advanced Quality Options #2962

Merged

Conversation

igiannakas
Copy link
Contributor

@igiannakas igiannakas commented Dec 2, 2023

Felt that the "advanced section" under "quality" needed a bit of a regrouping and cleanup, especially after the addition of all the new features in 1.8 and 1.9 which made it grow quite a bit and difficult to read in a glance :)

Also renamed the bridge flow and internal bridge flow to include the word "ratio" for consistency purposes with the remaining flow settings. Finally some more tweaks for consistency purposes.

This PR is a proposal on how this may look

Before:

image

After: (updated to include all commits in this PR)

image

@Eldenroot
Copy link
Contributor

Nice!

@igiannakas
Copy link
Contributor Author

igiannakas commented Dec 2, 2023

Updated PR with some extra tweaks (renamed the bridge flow and internal bridge flow to include the word "ratio" for consistency purposes with the remaining flow settings.)

@Eldenroot
Copy link
Contributor

Maybe this one should start with a capital letter? Srry CZE language.

image

…ing order. Updated walls printing order and print infill first tooltip
@igiannakas
Copy link
Contributor Author

igiannakas commented Dec 2, 2023

Done - updated and also improved tool tips and the wall order label. Latest screenshot is in the top post

@SoftFever
Copy link
Owner

Love it!

@igiannakas
Copy link
Contributor Author

@SoftFever I think its done :)

@igiannakas igiannakas changed the title Dev 1.9 - Regroup Advanced Quality Options QOL: Dev 1.9 - Regroup Advanced Quality Options Dec 3, 2023
@igiannakas
Copy link
Contributor Author

Looks like the build is crashing when opening. Investigating.

@igiannakas
Copy link
Contributor Author

Fixed - incorrectly transferred one option from another PR here hence the GUI was crashing.

PR is ready to merge.

@SoftFever SoftFever merged commit 82cb9e3 into SoftFever:main Dec 5, 2023
13 checks passed
@igiannakas igiannakas deleted the Dev-1.9---Regroup-Advanced-Quality-Options branch December 6, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants