Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bs1.8beta #2844

Merged
merged 936 commits into from
Dec 1, 2023
Merged

Feature/bs1.8beta #2844

merged 936 commits into from
Dec 1, 2023

Conversation

SoftFever
Copy link
Owner

@SoftFever SoftFever commented Nov 22, 2023 •
edited
Loading

Known issues:

  1. Print options missing for BBL printer
  2. Search by plate name not working
  3. inner outer inner wall seq broken

zorro.zhang and others added 30 commits November 9, 2023 10:09
@lanewei120
ENH: Show Recent File Image Keep Scale
05a5098 
Change-Id: Ib8a6cf916eaee8e353bf858bc4f2ea503705809e
@LiZ-Li-BBL @lanewei120
FIX: wipetower position problem
d7283d4 
jira: STUDIO-4914

Change-Id: I7b05d3c53931ed8ce3d4603ff21ee6ef675611e5
@LiZ-Li-BBL @lanewei120
FIX: dailytips adapts screen scale
0c7f991 
jira: STUDIO-5019 STUDIO-5026 STUDIO-5027 STUDIO-5028 STUDIO-5025

Change-Id: I63d3af1870218ba8e0f048a6ef03fb29fabe27cb
@DanBao-Bambu @lanewei120
FIX: generate process preset based on template
727db50 
Jira: XXXX

Change-Id: I50adf0790dc239307d236a4cebece860ef6beb16
Signed-off-by: maosheng.wei <[email protected]>
@bambu123 @lanewei120
FIX: object list plate name edit
ec18a18 
Change-Id: I61d3dcd7d9598d759a3a0b44cc77d2af2adca25a
Jira: STUDIO-4937
@walterwongbbl @lanewei120
ENH:no longer checking nozzle type
16881df 
jira:[for nozzle type check]

Change-Id: I0e88445a264f21b0c11519e9a22a165d05611d14
@ArthurBambulab @lanewei120
ENH: improve first layer tree support
7efebe6 
First layer support can't be top interface, and
min brim width of auto mode should be larger
than 0.

Jira: STUDIO-5010
Change-Id: I02f8b017b535f8a47965387e8679f692b1966e04
(cherry picked from commit 3e7d54abe352e8ab5f9d6492b5a86a96f9067f94)
@lanewei120
ENH: version: bumped to 1.8
55b27a0 
JIRA: no jira
Change-Id: I50903098b59f1dd9a6b6cf7656cec7d388f3ff17
@walterwongbbl @lanewei120
ENH:try again after subscription failure
1d41b0a 
jira:[Try again after subscription failure]

Change-Id: Ibfb1e8e26eb166d786a372632a86ef98030db034
@walterwongbbl @lanewei120
ENH:display msg dialog once
4fef36e 
jira:[for http error msg]

Change-Id: I12e9c155fdb567cac99c35b6feeef650269ba75d
@walterwongbbl @lanewei120
ENH:remove config.json file
eb9cc0c 
Change-Id: Idfcf3a63fefe968e88153c26fb691fd05cd83dc4
@walterwongbbl @lanewei120
ENH:add protection in threads
eaa7abf 
jira:[for random crash]

Change-Id: I6286012dd77abccba461f7cd72a6fc531a84c95f
@DanBao-Bambu @lanewei120
FIX: add protection for get_model_task_thread thread
5b5e5be 
Jira: XXXX

Change-Id: I3cbc17d181a0e13c658f31eaeb6a4df878e6df41
Signed-off-by: maosheng.wei <[email protected]>
@DanBao-Bambu @lanewei120
FIX: delete all compatible presets when delete third printer
342cab7 
Jira: XXXX

Change-Id: I1a294402627e7ab7a8c6701f20679b3d04aff059
Signed-off-by: maosheng.wei <[email protected]>
@lanewei120
ci: update build version to 01.08.00.51
0a2b9a7 
Change-Id: I20a01adacbdb5fe69c106b9efd029f7308136e10
@XunZhangBambu @lanewei120
ENH: default open support_interface_not_for_body
ce2af1e 
jira:[NEW]

Signed-off-by: xun.zhang <[email protected]>
Change-Id: I48e084deb18633f9ec47a8ec4ec643163bf66318
@walterwongbbl @lanewei120
ENH:modified text with too low version
542bc52 
jira:[for low version]

Change-Id: I862a0defda976a35f326a8805e002330f2ed7fdf
@walterwongbbl @lanewei120
NEW:update printer config file version
1d2a865 
Change-Id: I9a46b29b03beb67a3da0b8f76d8b5c4b3c482928
@Haidiye00 @lanewei120
FIX:The plane should rotate around the world coordinate system
30faa26 
Jira: STUDIO-5054
Change-Id: I16e484b38d79cabd9473acf1abf3c5c6b0adc4c6
@Haidiye00 @lanewei120
ENH:translate for limit file size and so on
a9637ea 
Jira: STUDIO-5007
Change-Id: I2c279eb690841aa51cd8128f8028266cbc17e977
@Haidiye00 @lanewei120
ENH:use on_render_rotate_gizmos() replace GLGizmoRotate3D::on_render()
e9dbf52 
Jira: STUDIO-4227
Change-Id: If9b9ea5596e59472d5fa87ac56aeb7f6ecc65643
@XunZhangBambu @lanewei120
FIX: some mistakes in filament profiles
4170639 
jira:[NEW]

Signed-off-by: xun.zhang <[email protected]>
Change-Id: Ibe7f3650f2d9cf47561dd5f2ec591a5f6c553503
@DanBao-Bambu @lanewei120
FIX: fix shard_ptr is null
1ac8c3e 
Change-Id: I0187cf64ffbb08a2265a11900b5c865e9ac9678f
@bam-winterfell @lanewei120
FIX:N1 printer image in dark mode
eddd01f 
JIRA:STUDIO-4057
Change-Id: I22c001d96839daf213d5096f6ff6e3d6398fa8c4
@DanBao-Bambu @lanewei120
FIX: create printer issue
d2cec94 
Jira: 5034 5059 5053
5034 create printer but filament is repeat
5039 create successful dialog remove to center
5053 create existing printer copywriting adjustments and preset updates
Delete printer secondary confirmation dialog

Change-Id: Ifb3822d1e168459d2af11e02b31ecaf3719d338a
Signed-off-by: maosheng.wei <[email protected]>
@walterwongbbl @lanewei120
ENH:just don't check the nozzle diameter
8a0c8ed 
jira:[for nozzle check]

Change-Id: I678e7d62832eaa14b9be47d6dce70f29ebd601f6
@bam-winterfell @lanewei120
NEW:p1 and x1 series added motor noise calibration
451a60f 
JIRA: 5085
Change-Id: Id73cc2d34b6130f215d81ffcdc39ba6b241445bf
@lanewei120
ci: update build version to 01.08.00.52
23b2edd 
Change-Id: I93d800b413f2751d132fac53fbd9b191603d0352
@MklBambu @lanewei120
FIX: ObjectSetting changed when search plate
8e246b4 
JIRA: STUDIO-5095

Signed-off-by: Kunlong Ma <[email protected]>
Change-Id: I39b1ad997d51ac4224ff5ad2b3555f56da4bd911
@XunZhangBambu @lanewei120
FIX: invalid support params in 3rd party profiles
278a773 
Many params are not right.Just use default

jira:[NEW]

Signed-off-by: xun.zhang <[email protected]>
Change-Id: I5c4a1e8b046940e174f5681a79031b5f20fcafc5
XunZhangBambu and others added 16 commits November 30, 2023 09:51
@XunZhangBambu @lanewei120
ENH: optimize param description
72ecc39 
jira:[NEW]

Signed-off-by: xun.zhang <[email protected]>
Change-Id: Id0ca9224227a716b21fc0b8430722264dc319344
@XunZhangBambu @lanewei120
ENH: add translation
b5f150b 
jira:[NEW]

Signed-off-by: xun.zhang <[email protected]>
Change-Id: I3b1f04fee3cd6322793794ad8b8707859f6c7d26
@DanBao-Bambu @lanewei120
FIX: close edit preset paramsDialog, mac unresponsive
dc9ddad 
Jira: 5298

Change-Id: I021e00567354cfb1f2f5f1f2bf6ba1fc35b164c5
@walterwongbbl @lanewei120
ENH:disable AI monitoring on the p1p series
899e28f 
Change-Id: I514bb1fb1ced6c03dd619230a9adac3be63f2de2
@lanewei120
ci: update build version to 01.08.01.52
2126999 
Change-Id: I9f5e30d3fc4b7ef9321c522d3c18fce98f03742f
@DanBao-Bambu @lanewei120
FIX: close edit preset paramsDialog, mac unresponsive
8ecafa3 
Change-Id: Ic816754a20b7f6a5cdb46475750eb301fec3ad3a
@ArthurBambulab @lanewei120
FIX: organic support not work with raft only
1106ff8 
There is no raft generated when only raft enabled but no support needed.
jira: none

Change-Id: Ic0c9269e2f98038d85c9bc54e4a85f892dc5d764
@lanewei120
FIX: CLI: add object config when assemble
a958f2f 
JIRA: no jira
Change-Id: I945f820fb58f2f643170b4b0b66742f6bbbdfd29
@DanBao-Bambu @lanewei120
FIX: delete preset prompt
b5aed4d 
Jira: XXXX

Change-Id: I6511c806c56393d4f6bd72d1c506da59675d49ff
@Haidiye00 @lanewei120
FIX:Reorganize the assignment of variables of "m_editing_window_width"
ed126ae 
Jira: STUDIO-5238
Change-Id: If369916f3f5c21510f5f297bfd05c1230bdda7a4
@lanewei120
ENH: CLI: re-compute flush_volumes_matrix when it is missed
3aa1539 
Change-Id: Ie8f53c6bef003b1434de02ea14de5787b376484f
@DanBao-Bambu @lanewei120
FIX: some translation for delete filament
56b7927 
Change-Id: Ib46a8eba33f2e21016476aaab4a57a740e86b1b8
@DanBao-Bambu @lanewei120
FIX: scrolled window / del preset / edit filament issue
fed7de9 
Jira: 5092
GitHub: 1936
edit filament: just one preset, the scroll bar obscures the preset name
edit filament: delete selected preset, click no, but preset be deleted
from UI
edit filament: serial sometimes displays incorrectly

Change-Id: Ibc91609e252179de0c05ca065099756da6631165
@lanewei120
ci: update build version to 01.08.01.53
1e8748a 
Change-Id: I5563a2c0812ab9a0d7727df27e17e681066ffa08
@SoftFever
Merge remote-tracking branch 'BS/master' into feature/bs1.8beta
6fb89b9
@SoftFever
Merge branch 'main' into feature/bs1.8beta
849fcdd 
# Conflicts:
#	localization/i18n/ru/OrcaSlicer_ru.po
#	src/slic3r/GUI/Preferences.cpp
@SoftFever
Copy link
Owner Author

hi @SoftFever looks like inner-outer-inner mode is broken following the merge. It always prints external to internal

Noted, and thanks for the review and testing. I'll be traveling for the next week and will address the fix when I return.

igiannakas@b3c3299

Fixed here :)

Thank you!
Do you mind to submit it once the PR is merged.
I can't find an easy way to cherry pick the commit

@SoftFever SoftFever mentioned this pull request Dec 1, 2023
Merged
5 tasks
@igiannakas
Copy link
Contributor

hi @SoftFever looks like inner-outer-inner mode is broken following the merge. It always prints external to internal

Noted, and thanks for the review and testing. I'll be traveling for the next week and will address the fix when I return.

igiannakas@b3c3299

Fixed here :)

Thank you! Do you mind to submit it once the PR is merged. I can't find an easy way to cherry pick the commit

Sure thing!

@SoftFever
Copy link
Owner Author

Note: CICD failed due to "resource busy" on macos-12, x86_64 instance.
Looks like runner issue.

@SoftFever SoftFever merged commit d8dd8fa into main Dec 1, 2023
12 of 13 checks passed
@igiannakas
Copy link
Contributor

hi @SoftFever looks like inner-outer-inner mode is broken following the merge. It always prints external to internal

Noted, and thanks for the review and testing. I'll be traveling for the next week and will address the fix when I return.

igiannakas@b3c3299

Fixed here :)

Thank you! Do you mind to submit it once the PR is merged. I can't find an easy way to cherry pick the commit

Done: #2949

@igiannakas
Copy link
Contributor

igiannakas commented Dec 1, 2023 •
edited
Loading

Another small bug - print options not showing in the pop up (Timelapse, PA calibration, bed levelling)

Screenshot 2023-11-23 at 09 22 36

@SoftFever btw this issue still happens :(

@igiannakas
Copy link
Contributor

Another small bug - print options not showing in the pop up (Timelapse, PA calibration, bed levelling)
Screenshot 2023-11-23 at 09 22 36

@SoftFever btw this issue still happens :(

Fixed here: #2951

@discip discip mentioned this pull request Dec 1, 2023
Closed
@igiannakas
Copy link
Contributor

igiannakas commented Dec 7, 2023 •
edited
Loading

Crash related to this PR: When clicking Calibration -> flow rate -> Pass 1 or Pass 2 application crashes as per below.
image
Crash Log.txt.zip

@igiannakas igiannakas mentioned this pull request Dec 7, 2023
Merged
@igiannakas
Copy link
Contributor

Fixed: #2994

@igiannakas
Copy link
Contributor

Also fixed the below issue in #2994

The seam placer files were overwritten in the above merge which removed the code segments from the Prusa feature import for staggered seams. Reverting that change from BS in this PR too.

Left - before, right - after

image

@SoftFever SoftFever deleted the feature/bs1.8beta branch December 26, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.