Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds overview for custom gcodes like pause, change filament, custom #2191 #2728

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

niklasb22
Copy link
Contributor

This inserts an overview of all inserted user-specified gcodes, such as the filament change, pause and custom gcodes.
The layer on which the gcode is located is displayed, as well as a time estimate.
If there is no user-specified gcode in the print, nothing is displayed.

image

Closes: #2191

@Eldenroot
Copy link
Contributor

Please, check alsonthe issue / request for the First Layer Times and adding filament used for every type of part of model. Like IT is in Prusa

@Eldenroot
Copy link
Contributor

#2252 this oné, including icons

@discip
Copy link
Contributor

discip commented Nov 15, 2023

@niklasb22

Thank you! 👍🏻


Unfortunately there is an issue regarding the time as the current approach shows the time of the layer after it is finished.

But unfortunately we need the time before the layer starts.

Please see the conversation here #2312.

Copy link
Collaborator

@Noisyfox Noisyfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should show the previous layer time as mentioned in the comment.

@niklasb22 niklasb22 requested a review from Noisyfox November 16, 2023 18:29
@niklasb22
Copy link
Contributor Author

@discip The time display should now be correct.

@Noisyfox Noisyfox added this to the 1.9.0 milestone Nov 17, 2023
@Noisyfox Noisyfox added the enhancement New feature or request label Nov 17, 2023
Copy link
Collaborator

@Noisyfox Noisyfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.

@discip
Copy link
Contributor

discip commented Nov 17, 2023

@niklasb22

Thank you very much! 😀👍🏻

As Noisyfox stated, this is good to go.

@SoftFever
Copy link
Owner

Very handy feature.
Thank you very much 👍

@SoftFever SoftFever merged commit 8ca0d79 into SoftFever:main Nov 18, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add time estimation for pauses (so you know when to insert magnets / nuts ...)
5 participants