Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various infill improvements #2716

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Conversation

Noisyfox
Copy link
Collaborator

@Noisyfox Noisyfox commented Nov 13, 2023

  1. Fix issue that sparse infill threshold no longer working
  2. Turn all internal sparse infill into solid infill if infill density is 100%
  3. Allow combining solid infill when sparse infill density is 100%
  4. Move internal solid infill pattern settings into the Infill section

This should fix #2645

@Noisyfox Noisyfox added this to the 1.9.0 milestone Nov 16, 2023
@Noisyfox Noisyfox added bug Something isn't working enhancement New feature or request labels Nov 16, 2023
@SoftFever
Copy link
Owner

The sparse infill threshold in 1.8 works fine for me.
In which situation it didn't work?

Left with threshold set to 15, right 0
image

sparse-infill-threshold.zip

@Noisyfox
Copy link
Collaborator Author

Yeah there are some extreme rare cases that could reproduce the problem, such as the model from #2645:

ae0f47b9aa9287362925fbf8fbb77e10

As shown in the screenshot, the red area is no where close to 10000 mm2 yet it is still sparse infill.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SoftFever SoftFever merged commit 0fa884d into SoftFever:main Nov 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slicer creating geometry inside infill underneath the actual geometry
2 participants