Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organic: Fix support blocker #2595

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

Noisyfox
Copy link
Collaborator

@Noisyfox Noisyfox commented Nov 3, 2023

This fixes issue that support blocker produces different results when switching between organic/non-organic tree supports.

image

Before:
image

After:
1b2f962b86b08848e4aba543bc9890ba

呼呼呼碳纤维1.zip

@SoftFever
Copy link
Owner

Hey @Noisyfox

May I ask you to create a separate PR that contains only the 'remove small overhang' fix, so we can include it in the 1.8 release?

@Noisyfox Noisyfox force-pushed the bugfix/overhang-block branch from cf99527 to 4c8889c Compare November 3, 2023 14:13
@Noisyfox Noisyfox changed the title Use BBS' overhang detection algorithm for organic support Organic: Fix support blocker Nov 3, 2023
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SoftFever
Copy link
Owner

Cool, thanks!

@SoftFever SoftFever merged commit 528fb63 into SoftFever:main Nov 3, 2023
4 checks passed
@Noisyfox Noisyfox deleted the bugfix/overhang-block branch November 4, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants