-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macOS deps build issues #2541
Fix macOS deps build issues #2541
Conversation
@@ -133,6 +133,7 @@ else() | |||
${_gen} | |||
CMAKE_ARGS | |||
-DCMAKE_INSTALL_PREFIX:STRING=${DESTDIR}/usr/local | |||
-DCMAKE_PREFIX_PATH:STRING=${DESTDIR}/usr/local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMAKE_PREFIX_PATH is what tells cmake where to search for packages. On cross compiled apple devices this was not being set and would allow cmake to find dependencies elsewhere on the system. This specifically caused issues when cmake used version 3 of OpenSSL rather than version 1 needed by Orca and may have caused other issues after that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice catch!
@@ -30,7 +30,8 @@ else () | |||
URL_HASH SHA256=cf4f4b2d80abb79e820e78c8077b6725bbbb4e8f41896783c899087be0e94068 | |||
DOWNLOAD_DIR ${DEP_DOWNLOAD_DIR}/MPFR | |||
BUILD_IN_SOURCE ON | |||
CONFIGURE_COMMAND env "CFLAGS=${_gmp_ccflags}" "CXXFLAGS=${_gmp_ccflags}" ./configure ${_cross_compile_arg} --prefix=${DESTDIR}/usr/local --enable-shared=no --enable-static=yes --with-gmp=${DESTDIR}/usr/local ${_gmp_build_tgt} | |||
CONFIGURE_COMMAND autoreconf -f -i && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add autoreconf command to prevent issue while configuring MPFR where the configure command fails because it thinks it is out of date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried it before but for some reason it didn't work. Maybe I missed something that time
That's awesome. |
Maybe not in the scope of this PR, will this fix this error after upgrading to Sonoma?
|
Have you tried building from this PR to see if this fixes it?
|
No, dependancies seems to be unsync for latest macos release. Had to install
|
Based on the log provided, this PR should fix the issue you are having. The PR adds this line to the Cmake file for the main project. The link describes it's function too, but tldr, it tells Cmake where to find the built dependencies. Your log shows it is trying to use packages from elsewhere on the system. |
I think i messed up something, build succeeded from a brand new clone. There is still quite a few warnings about outdated dependancies, but not related to your pr.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thank you very much!
update deps/CMakeLists.txt and MPFR.cmake
cd ~/VSCode fails: building slicer...
-- Configuring incomplete, errors occurred! |
You will need to build dependencies for the first time. |
|
I'm not sure. Meanwhile, GitHub isn't the best place for this kind of help. |
Fixes the issues with macOS dependency builds via GitHub Actions.