-
-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/measure tool port - NOT READY #2434
Conversation
Fixes/Updates: 1. Shift typo fixed 2. "Pengrootte" is supposed to be one word. 3. "Gebied" doesn't sound right for a shape, "Bol" is better. 4. "Sectie weergave" is two words
Co-authored-by: ZdDroid <[email protected]>
Did what I could for now!
* 选择打印机增加关键字搜索 * revert more format changes --------- Co-authored-by: ZdDroid <[email protected]> Co-authored-by: SoftFever <[email protected]>
this also fixes #2344
Wau! Good job, looking for a working version |
@SoftFever wanted to pass along that I am currently not able to get it to build. Seems there are some conflicts with the array constructor for the ColorRGBA class. For some reason it seams that when passing one of the const colors (the error is specifically pointing to the color initis in the GLGizmoBase::,Grabber struct) it is trying to use the array constructor rather than the (const ColorRGBA& other) constructor. LMK if there is any more info/help I can provide. |
I got it fixed on my branch: Noisyfox@048e440 |
Oops, it compiled on my machine. |
Ah, a new ColorRGBA class has been introduced. As @Noisyfox figured in his comment above ^^ |
As for the remaining work, currently a lot of gizmo tools are broken as them need to migrate to the new grabber/picking approach. |
Please ref to #2603 |
It's far from ready.
For discussion only.
Measure tool works, but other tools are broken.
@Noisyfox