Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/measure tool port - NOT READY #2434

Closed
wants to merge 19 commits into from
Closed

Conversation

SoftFever
Copy link
Owner

It's far from ready.
For discussion only.

Measure tool works, but other tools are broken.
@Noisyfox

SoftFever and others added 16 commits October 9, 2023 22:58
Fixes/Updates:

1. Shift typo fixed
2. "Pengrootte" is supposed to be one word.
3. "Gebied" doesn't sound right for a shape, "Bol" is better.
4. "Sectie weergave" is two words
Did what I could for now!
* 选择打印机增加关键字搜索

* revert more format changes

---------

Co-authored-by: ZdDroid <[email protected]>
Co-authored-by: SoftFever <[email protected]>
@Eldenroot
Copy link
Contributor

Wau! Good job, looking for a working version

@Ocraftyone
Copy link
Contributor

@SoftFever wanted to pass along that I am currently not able to get it to build. Seems there are some conflicts with the array constructor for the ColorRGBA class. For some reason it seams that when passing one of the const colors (the error is specifically pointing to the color initis in the GLGizmoBase::,Grabber struct) it is trying to use the array constructor rather than the (const ColorRGBA& other) constructor. LMK if there is any more info/help I can provide.

@Noisyfox
Copy link
Collaborator

@SoftFever wanted to pass along that I am currently not able to get it to build. Seems there are some conflicts with the array constructor for the ColorRGBA class. For some reason it seams that when passing one of the const colors (the error is specifically pointing to the color initis in the GLGizmoBase::,Grabber struct) it is trying to use the array constructor rather than the (const ColorRGBA& other) constructor. LMK if there is any more info/help I can provide.

I got it fixed on my branch: Noisyfox@048e440

@SoftFever
Copy link
Owner Author

Oops, it compiled on my machine.
Maybe some last minute change broke the build

@SoftFever
Copy link
Owner Author

SoftFever commented Oct 18, 2023

@SoftFever wanted to pass along that I am currently not able to get it to build. Seems there are some conflicts with the array constructor for the ColorRGBA class. For some reason it seams that when passing one of the const colors (the error is specifically pointing to the color initis in the GLGizmoBase::,Grabber struct) it is trying to use the array constructor rather than the (const ColorRGBA& other) constructor. LMK if there is any more info/help I can provide.

Ah, a new ColorRGBA class has been introduced.
You can convert the array to ColorRGBA. I believe I've made the necessary changes in most places. If you search through the codebase, you should find how to address them for this error.
I haven't been working on Windows lately, so I might have overlooked some adjustments, especially if these errors are unique to Windows.

As @Noisyfox figured in his comment above ^^

@SoftFever
Copy link
Owner Author

As for the remaining work, currently a lot of gizmo tools are broken as them need to migrate to the new grabber/picking approach.
The build is working expect most gizmo tools.
Though I expect many bugs and quirks need to be addressed.

@SoftFever
Copy link
Owner Author

Please ref to #2603

@SoftFever SoftFever closed this Nov 4, 2023
@SoftFever SoftFever deleted the feature/measure_port branch December 17, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants