Fix object's list text color on Linux (GH-2086) #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you don't want the related issue to be closed, you would need to change the quoted line as exactly that will definitely happen due to GitHub Docs if you leave it like this. 😊 Maybe something like: partially fixes issue #2086 |
Good advice, changed to:
|
SoftFever
approved these changes
Oct 8, 2023
| @@ -91,6 +91,13 @@ ObjectList::ObjectList(wxWindow* parent) : | |||
| wxDataViewCtrl(parent, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxDV_MULTIPLE) | |||
| { | |||
| wxGetApp().UpdateDVCDarkUI(this, true); | |||
|
|
|||
| #ifdef __linux__ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial solution for #2086 (do not close - this PR does not fully fix the issue, it just makes one place better)
This PR focuses on fixing the Object's list text rendering on linux-based OSes. As some people reported, for Linux users with Dark mode enabled, the Object's list renders its text in black-ish color, making it impossible to read. I'm not sure about that in general, but for me at least, switching temporarily to light mode also didn't fix the problem (comparing to other places where that trick does fix the problem, temporarily), as it was rendered all white.
The proposed fix for that is quite simple - for linux platforms, apply the base text color, which then seems to be handled by dark mode color changing as expected.
Comparison
Before
After