Ported automatic hole to polyhole conversion from superslicer #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoftFever
requested changes
Oct 6, 2023
There was a problem hiding this comment.
@lovelytwo Thank you for porting this feature 👍
Overall it looks good.
Do you think if we can add the original author as co-author here?
We use Co-authored-by: for it: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors
lovelytwo
force-pushed
the
feature/port-polyholes
branch
from
d5cc137 to
f5efe0c
Compare
Co-authored-by: supermerill <[email protected]>
lovelytwo
force-pushed
the
feature/port-polyholes
branch
from
f5efe0c to
3359dad
Compare
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've ported automatic polyhole conversion from super slicer.
I'm happy to change the PR as required.
Closes #626