Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with STL builds of wxWidgets #2218

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

mia-0
Copy link
Contributor

@mia-0 mia-0 commented Sep 24, 2023

This removes the dependency on legacy wxWidgets configurations, and makes OrcaSlicer compile on STL builds.

Also, the wxStringList class has been obsolete for at least 20 years, and disappeared from the documentation.
Replace with wxArrayString.

This removes the dependency on legacy wxWidgets configurations,
and makes OrcaSlicer compile on STL builds.

Also, the wxStringList class has been obsolete for at least 20
years, and disappeared from the documentation.
Replace with wxArrayString.
@SoftFever
Copy link
Owner

@mia-0
Thanks for the PR.
Curious, what is STL build?

@mia-0
Copy link
Contributor Author

mia-0 commented Sep 25, 2023

wxWidgets built to use STL classes instead of the legacy implementations written before those were widely available. This will be the only option starting with wxWidgets 3.3, and has been the default for some major Linux distros for several years.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoftFever
Copy link
Owner

wxWidgets built to use STL classes instead of the legacy implementations written before those were widely available. This will be the only option starting with wxWidgets 3.3, and has been the default for some major Linux distros for several years.

Thanks for the explaination.
Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants