Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port "Extend sparse infill" from Prusa #2134

Merged
merged 8 commits into from
Sep 29, 2023

Conversation

Noisyfox
Copy link
Collaborator

@Noisyfox Noisyfox commented Sep 16, 2023

#1165

image
image

This also removes the "internal_bridge_support_thickness" option as it's replaced by the extend sparse infill feature and no longer needed.

@Noisyfox
Copy link
Collaborator Author

Also this PR includes changes from #2132.

@igiannakas
Copy link
Contributor

igiannakas commented Sep 17, 2023

Hi Noisyfox, excellent work!! Ps. does this also contain the code for the vertical shell thickness? Would love to test that out compared to Bambus implementation.

@Noisyfox
Copy link
Collaborator Author

Noisyfox commented Sep 17, 2023

Hi Noisyfox, excellent work!! Ps. does this also contain the code for the vertical shell thickness? Would love to test that out compared to Bambus implementation.

Nope, because it's a bit more complex to keep both the Bambu's implementation and Prusa's, so I decided not to include it ATM.

@SoftFever
Copy link
Owner

@Noisyfox
Fantastic!

I noticed some area is not achored properly.
Any idea what could be the cause?

image
extended_sparse_infill_layer_188_issue.zip

@Noisyfox
Copy link
Collaborator Author

@Noisyfox Fantastic!

I noticed some area is not achored properly. Any idea what could be the cause?

image extended_sparse_infill_layer_188_issue.zip

image
Fixed

@Noisyfox
Copy link
Collaborator Author

Noisyfox commented Sep 29, 2023

I've further improved the algorithm so it finds the optimal bridge direction under extreme conditions (0% infill):
Prusa(left) vs our improved version(right):
image
image

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoftFever
Copy link
Owner

Awesome!

@SoftFever SoftFever merged commit ee0e6a7 into SoftFever:main Sep 29, 2023
@Creo2005
Copy link

Screenshot 2023-10-30 090337
in latest beta I don't see these options.

@Noisyfox
Copy link
Collaborator Author

Screenshot 2023-10-30 090337 in latest beta I don't see these options.

There is no options for this. It's on permanently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants