Fix issue that the slice button is still disabled after a tick is del…

…eted (#2308) Fix an UAF which causes the slice button being disabled after a tick is deleted
SoftFever · Oct 3, 2023 · 8e70081 · 8e70081
1 parent 85e24e6
commit 8e70081
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/slic3r/GUI/IMSlider.cpp b/src/slic3r/GUI/IMSlider.cpp
@@ -405,8 +405,9 @@ void IMSlider::add_code_as_tick(Type type, int selected_extruder)
 }
 
 void IMSlider::delete_tick(const TickCode& tick) {
+    Type t = tick.type; // Avoid Use-After-Free issue, which resets the tick.type to 0
     m_ticks.ticks.erase(tick);
-    post_ticks_changed_event(tick.type);
+    post_ticks_changed_event(t);
 }
 
 bool IMSlider::check_ticks_changed_event(Type type)