Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore step7.py as it requires the serial module #254

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Ignore step7.py as it requires the serial module #254

merged 1 commit into from
Dec 20, 2023

Conversation

alxbilger
Copy link
Member

Since #246

@alxbilger alxbilger changed the title Ignore step7.py as it require the serial module Ignore step7.py as it requires the serial module Dec 19, 2023
@alxbilger
Copy link
Member Author

@bakpaul what do you think? Do we merge it, or do you prefer to install the module on the builders?

@bakpaul
Copy link
Collaborator

bakpaul commented Dec 19, 2023

If I remember well, this scene test some connection with the robot. If this is true, then it doesn't make sens to test it on the ci...

@alxbilger alxbilger merged commit 6f27ce2 into SofaDefrost:master Dec 20, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EulalieCoevoet EulalieCoevoet EulalieCoevoet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alxbilger @bakpaul @EulalieCoevoet