v5.2.0 - Clone data by default so that we get consistent behaviour be…

…tween connected and disconnected sockets

bower.json

@@ -1,7 +1,7 @@
 {
   "name": "socketcluster-client",
   "main": "socketcluster.js",
-  "version": "5.1.1",
+  "version": "5.2.0",
   "homepage": "https://github.com/SocketCluster/socketcluster-client",
   "description": "SocketCluster JavaScript client",
   "authors": [

index.js

@@ -14,4 +14,4 @@ module.exports.destroy = function (options) {
   return SCSocketCreator.destroy(options);
 };
 
-module.exports.version = '5.1.1';
+module.exports.version = '5.2.0';

lib/scsocket.js

@@ -7,6 +7,7 @@ var SCTransport = require('./sctransport').SCTransport;
 var querystring = require('querystring');
 var LinkedList = require('linked-list');
 var base64 = require('base-64');
+var cloneDeep = require('lodash.clonedeep');
 
 var scErrors = require('sc-errors');
 var InvalidArgumentsError = scErrors.InvalidArgumentsError;
@@ -625,7 +626,7 @@ SCSocket.prototype._flushEmitBuffer = function () {
     nextNode = currentNode.next;
     var eventObject = currentNode.data;
     currentNode.detach();
-    this.transport.emitRaw(eventObject);
+    this.transport.emitObject(eventObject);
     currentNode = nextNode;
   }
 };
@@ -655,7 +656,12 @@ SCSocket.prototype._emit = function (event, data, callback) {
   };
 
   var eventNode = new LinkedList.Item();
-  eventNode.data = eventObject;
+
+  if (this.options.cloneData) {
+    eventNode.data = cloneDeep(eventObject);
+  } else {
+    eventNode.data = eventObject;
+  }
 
   eventObject.timeout = setTimeout(function () {
     self._handleEventAckTimeout(eventObject, eventNode);

lib/scsocketcreator.js

@@ -68,7 +68,8 @@ function connect(options) {
     authEngine: null,
     authTokenName: 'socketCluster.authToken',
     binaryType: 'arraybuffer',
-    multiplex: true
+    multiplex: true,
+    cloneData: true
   };
   for (var i in options) {
     if (options.hasOwnProperty(i)) {

lib/sctransport.js

@@ -250,7 +250,7 @@ SCTransport.prototype.close = function (code, data) {
   }
 };
 
-SCTransport.prototype.emitRaw = function (eventObject) {
+SCTransport.prototype.emitObject = function (eventObject) {
   var simpleEventObject = {
     event: eventObject.event,
     data: eventObject.data
@@ -265,7 +265,6 @@ SCTransport.prototype.emitRaw = function (eventObject) {
   return eventObject.cid || null;
 };
 
-
 SCTransport.prototype._handleEventAckTimeout = function (eventObject) {
   var errorMessage = "Event response for '" + eventObject.event + "' timed out";
   var error = new TimeoutError(errorMessage);
@@ -310,7 +309,7 @@ SCTransport.prototype.emit = function (event, data, a, b) {
 
   var cid = null;
   if (this.state == this.OPEN || options.force) {
-    cid = this.emitRaw(eventObject);
+    cid = this.emitObject(eventObject);
   }
   return cid;
 };
@@ -335,7 +334,7 @@ SCTransport.prototype.send = function (data) {
   }
 };
 
-SCTransport.prototype.sendObject = function (object) {
+SCTransport.prototype.serializeObject = function (object) {
   var str, formatError;
   try {
     str = this.encode(object);
@@ -344,6 +343,14 @@ SCTransport.prototype.sendObject = function (object) {
     this._onError(formatError);
   }
   if (!formatError) {
+    return str;
+  }
+  return null;
+};
+
+SCTransport.prototype.sendObject = function (object) {
+  var str = this.serializeObject(object);
+  if (str != null) {
     this.send(str);
   }
 };

package.json

@@ -1,7 +1,7 @@
 {
   "name": "socketcluster-client",
   "description": "SocketCluster JavaScript client",
-  "version": "5.1.1",
+  "version": "5.2.0",
   "homepage": "http://socketcluster.io",
   "contributors": [
     {
@@ -16,6 +16,7 @@
   "dependencies": {
     "base-64": "0.1.0",
     "linked-list": "0.1.0",
+    "lodash.clonedeep": "4.5.0",
     "querystring": "0.2.0",
     "sc-channel": "1.0.x",
     "sc-emitter": "1.0.x",