-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: format observedAt proprement pour éviter un bug de tri dans les statistiques #1819
Conversation
@@ -22,6 +22,7 @@ export const customFieldsObsSelector = selector({ | |||
key: 'customFieldsObsSelector', | |||
get: ({ get }) => { | |||
const organisation = get(organisationState); | |||
if (!organisation) return defaultCustomFields; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sans cette ligne, la migration plante parce que organisation
n'est pas encore défini
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est bon pour moi !
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
🎉 Deployment for commit bb6272b : IngressesDocker images
|
## [1.302.3](v1.302.2...v1.302.3) (2024-01-10) ### Bug Fixes * format observedAt proprement pour éviter un bug de tri dans les statistiques ([#1819](#1819)) ([dd4f90e](dd4f90e))
🎉 This PR is included in version 1.302.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
j'ai un excerpt des données d'une organisation pour laquelle li y a un bug notoire de statistiques d'observations de territoires (https://trello.com/c/8zAAkkVg)
il se trouve que certaines observations ont un timestamp en guise de valeur de
observedAt
, d'autre rien du tout, d'autre une date ISOc'est probable que le bug soit lié à ce problème
j'ai essayé rapidement de reproduire le problème, je n'ai pas réussi - je n'ai pas le temps de me pencher plus sur l'historique git ou quoique ce soit, donc j'abandonne
en revanche je suis optimiste pour la résolution du bug des stats