Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format observedAt proprement pour éviter un bug de tri dans les statistiques #1819

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

arnaudambro
Copy link
Contributor

@arnaudambro arnaudambro commented Jan 9, 2024

j'ai un excerpt des données d'une organisation pour laquelle li y a un bug notoire de statistiques d'observations de territoires (https://trello.com/c/8zAAkkVg)
il se trouve que certaines observations ont un timestamp en guise de valeur de observedAt, d'autre rien du tout, d'autre une date ISO
c'est probable que le bug soit lié à ce problème

j'ai essayé rapidement de reproduire le problème, je n'ai pas réussi - je n'ai pas le temps de me pencher plus sur l'historique git ou quoique ce soit, donc j'abandonne

en revanche je suis optimiste pour la résolution du bug des stats

@@ -22,6 +22,7 @@ export const customFieldsObsSelector = selector({
key: 'customFieldsObsSelector',
get: ({ get }) => {
const organisation = get(organisationState);
if (!organisation) return defaultCustomFields;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sans cette ligne, la migration plante parce que organisation n'est pas encore défini

@arnaudambro
Copy link
Contributor Author

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@rap2hpoutre rap2hpoutre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est bon pour moi !

Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Jan 9, 2024

🎉 Deployment for commit bb6272b :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/mano/mano/api:sha-bb6272bd882ea5267a8d7711567ee06246cacb16
  • 📦 docker pull harbor.fabrique.social.gouv.fr/mano/mano/dashboard:sha-bb6272bd882ea5267a8d7711567ee06246cacb16
  • 📦 docker pull harbor.fabrique.social.gouv.fr/mano/mano/www:sha-bb6272bd882ea5267a8d7711567ee06246cacb16
Debug

@arnaudambro arnaudambro merged commit dd4f90e into main Jan 10, 2024
10 checks passed
@arnaudambro arnaudambro deleted the fix/observedat-observations branch January 10, 2024 08:17
SocialGroovyBot added a commit that referenced this pull request Jan 10, 2024
## [1.302.3](v1.302.2...v1.302.3) (2024-01-10)

### Bug Fixes

* format observedAt proprement pour éviter un bug de tri dans les statistiques ([#1819](#1819)) ([dd4f90e](dd4f90e))
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 1.302.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants