Update aggregate message origin #38
Conversation
| use bridge_hub_common::{ | ||
| message_queue::{NarrowOriginToSibling, ParaIdToSibling}, | ||
| AggregateMessageOrigin, | ||
| }; |
There was a problem hiding this comment.
Are we gonna merge our changes to all bridge-hub runtimes including Kusama and Polkadot, or just focus on the Rococo runtime?
There was a problem hiding this comment.
Hmmm that's a good point. All our other config changes are just on the Rococo runtime, so let me revert the Kusama, Westend and Polkadot changes.
There was a problem hiding this comment.
I get compiler errors if I don't update all the runtimes. I think its because it all the bridge hub runtime use bridge_hub_common for NarrowOriginToSibling and ParaIdToSibling, and then AggregateMessageOrigin needs to be consistent (can't mix using AggregateMessageOrigin in bridge_hub_common and then the runtime uses the AggregateMessageOrigin in the cumulus primitives.
claravanstaden
force-pushed
the
update-aggregate-message-origin
branch
from
e26d6fa to
a94b564
Compare
| @@ -226,33 +226,23 @@ fn register_token() { | |||
|
|
|||
| #[test] | |||
| fn send_token_to_penpal() { | |||
There was a problem hiding this comment.
This test fails, not sure why yet.
There was a problem hiding this comment.
Awesome, thanks @yrong!
...arachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs
Show resolved
Hide resolved
claravanstaden
force-pushed
the
update-aggregate-message-origin
branch
from
b8bc017 to
58f5dd9
Compare
Snowbridge companion: Snowfork/snowbridge#1024