Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove deprecated resources, data sources, and fields in config #3215

Merged
merged 9 commits into from
Nov 25, 2024
Merged

chore: Remove deprecated resources, data sources, and fields in config #3215

merged 9 commits into from
Nov 25, 2024

Conversation

sfc-gh-jmichalak
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak commented Nov 21, 2024 •
edited
Loading

  • remove deprecated data sources and resources
    • some of the tag related fields are not removed - will be done after merging feat: Tag association v1 readiness #3210
    • some resources (procedures, functions, unsafe_execute) are not removed - can be done after reworking
  • remove deprecated fields in the provider config
    • deprecated fields in the resources/data sources that we haven't reworked are still there
  • remove some unused code from snowflake package
  • remove deprecated JWT value from authenticator
  • improve doc generator, so that the headers are added only in case of non-empty lists
    • I have left some comments in the templates because the generated files must not be blank

Test Plan

  • acceptance tests
  • …

TODO

  • remove objects related with tags, procedures, functions, unsafe_execute

@github-actions GitHub Actions
Copy link

Integration tests failure for 73ccdad8f8c32879408144aa09bbae707977f04a

@github-actions GitHub Actions
Copy link

Integration tests failure for 620960e2db4e9d93875fd67d28277c00cc2ed622

@sfc-gh-jmichalak sfc-gh-jmichalak marked this pull request as ready for review November 22, 2024 13:54
@github-actions GitHub Actions
Copy link

Integration tests failure for daa0a33b10ed17680b658ca50b0ba2bed01dd8a3

@github-actions GitHub Actions
Copy link

Integration tests failure for b62ff276088f763aec77e1f164cb079b9efab92e

1 similar comment
@github-actions GitHub Actions
Copy link

Integration tests failure for b62ff276088f763aec77e1f164cb079b9efab92e

sfc-gh-asawicki
sfc-gh-asawicki requested changes Nov 24, 2024
View reviewed changes
docs/technical-documentation/resource_migration.md Outdated Show resolved Hide resolved
pkg/datasources/parameters_acceptance_test.go Show resolved Hide resolved
pkg/provider/provider_helpers.go Show resolved Hide resolved
pkg/sdk/config.go Show resolved Hide resolved
pkg/sdk/helper_test.go Show resolved Hide resolved
v1-preparations/LIST_OF_REMOVED_RESOURCES_FOR_V1.md Show resolved Hide resolved
sfc-gh-jcieslak
sfc-gh-jcieslak reviewed Nov 25, 2024
View reviewed changes
MIGRATION_GUIDE.md
<!-- TODO(next pr): link to entries in the migration guide regarding details for each of the resource/data source-->
- Resources
- `snowflake_database_old`
- `snowflake_role`
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about snowflake_roles (data source)? It's not deprecated, but maybe should be removed (?). We could also leave it and transform it into the generic data source for roles.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Let's discuss it separately, and do this in another PR, if needed.

@github-actions GitHub Actions
Copy link

Integration tests failure for 06d6171820d4e14fc87e4a1f6119c76b430d00b9

@github-actions GitHub Actions
Copy link

Integration tests failure for fb65fa3d0af71b2faad00e87cfa6c625bff4b789

@sfc-gh-jmichalak sfc-gh-jmichalak merged commit 929bd5d into v1-ready Nov 25, 2024
8 of 9 checks passed
@sfc-gh-jmichalak sfc-gh-jmichalak deleted the v1-ready-remove-deprecated branch November 25, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jmichalak @sfc-gh-jcieslak @sfc-gh-asawicki