Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gles: Define a TextureShaderElement #1560

Merged
merged 1 commit into from
Oct 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/backend/renderer/element/texture.rs
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ pub struct TextureRenderElement<T> {
location: Point<f64, Physical>,
id: Id,
renderer_id: usize,
texture: T,
pub(crate) texture: T,
scale: i32,
transform: Transform,
alpha: f32,
Expand Down
102 changes: 98 additions & 4 deletions src/backend/renderer/gles/element.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

use crate::{
backend::renderer::{
element::{Element, Id, Kind, RenderElement, UnderlyingStorage},
utils::{CommitCounter, OpaqueRegions},
element::{texture::TextureRenderElement, Element, Id, Kind, RenderElement, UnderlyingStorage},
utils::{CommitCounter, DamageSet, OpaqueRegions},
},
utils::{Buffer, Logical, Physical, Rectangle, Scale, Transform},
utils::{Buffer, Logical, Physical, Point, Rectangle, Scale, Transform},
};

use super::{GlesError, GlesFrame, GlesPixelProgram, GlesRenderer, Uniform};
use super::{GlesError, GlesFrame, GlesPixelProgram, GlesRenderer, GlesTexProgram, GlesTexture, Uniform};

/// Render element for drawing with a gles2 pixel shader
#[derive(Debug, Clone)]
Expand Down Expand Up @@ -129,3 +129,97 @@ impl RenderElement<GlesRenderer> for PixelShaderElement {
None
}
}

/// Render element for drawing with a gles2 texture shader
#[derive(Debug)]
pub struct TextureShaderElement {
inner: TextureRenderElement<GlesTexture>,
program: GlesTexProgram,
id: Id,
additional_uniforms: Vec<Uniform<'static>>,
}

impl TextureShaderElement {
/// Create a new [`TextureShaderElement`] from a [`TextureRenderElement`] and a
/// [`GlesTexProgram`], which can be constructed using
/// [`GlesRenderer::compile_custom_texture_shader`]
pub fn new(
inner: TextureRenderElement<GlesTexture>,
program: GlesTexProgram,
additional_uniforms: Vec<Uniform<'_>>,
) -> Self {
Self {
inner,
program,
id: Id::new(),

additional_uniforms: additional_uniforms.into_iter().map(|u| u.into_owned()).collect(),
}
}
}

impl Element for TextureShaderElement {
fn id(&self) -> &Id {
&self.id
}

fn current_commit(&self) -> CommitCounter {
self.inner.current_commit()
}

fn geometry(&self, scale: Scale<f64>) -> Rectangle<i32, Physical> {
self.inner.geometry(scale)
}

fn transform(&self) -> Transform {
self.inner.transform()
}

fn src(&self) -> Rectangle<f64, Buffer> {
self.inner.src()
}

fn damage_since(&self, scale: Scale<f64>, commit: Option<CommitCounter>) -> DamageSet<i32, Physical> {
self.inner.damage_since(scale, commit)
}

fn opaque_regions(&self, scale: Scale<f64>) -> OpaqueRegions<i32, Physical> {
self.inner.opaque_regions(scale)
}

fn alpha(&self) -> f32 {
self.inner.alpha()
}

fn kind(&self) -> Kind {
self.inner.kind()
}

fn location(&self, scale: Scale<f64>) -> Point<i32, Physical> {
self.inner.location(scale)
}
}

impl RenderElement<GlesRenderer> for TextureShaderElement {
#[profiling::function]
fn draw(
&self,
frame: &mut GlesFrame<'_>,
src: Rectangle<f64, Buffer>,
dst: Rectangle<i32, Physical>,
damage: &[Rectangle<i32, Physical>],
opaque_regions: &[Rectangle<i32, Physical>],
) -> Result<(), GlesError> {
frame.render_texture_from_to(
&self.inner.texture,
src,
dst,
damage,
opaque_regions,
self.transform(),
self.alpha(),
Some(&self.program),
&self.additional_uniforms,
)
}
}
18 changes: 18 additions & 0 deletions src/backend/renderer/glow.rs
Original file line number Diff line number Diff line change
Expand Up @@ -553,3 +553,21 @@ impl RenderElement<GlowRenderer> for PixelShaderElement {
RenderElement::<GlesRenderer>::underlying_storage(self, renderer.borrow_mut())
}
}

impl RenderElement<GlowRenderer> for TextureShaderElement {
#[profiling::function]
fn draw(
&self,
frame: &mut GlowFrame<'_>,
src: Rectangle<f64, BufferCoord>,
dst: Rectangle<i32, Physical>,
damage: &[Rectangle<i32, Physical>],
opaque_regions: &[Rectangle<i32, Physical>],
) -> Result<(), GlesError> {
RenderElement::<GlesRenderer>::draw(self, frame.borrow_mut(), src, dst, damage, opaque_regions)
}

fn underlying_storage(&self, renderer: &mut GlowRenderer) -> Option<UnderlyingStorage<'_>> {
RenderElement::<GlesRenderer>::underlying_storage(self, renderer.borrow_mut())
}
}
Loading