Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed network scan #2906

Merged
merged 5 commits into from
Oct 31, 2024
Merged

fixed network scan #2906

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
94812d8
fixed network scan
pljakobs Oct 31, 2024
f2fbdc5
removed call to `esp_wifi_scan_get_ap_num` entirely
pljakobs Oct 31, 2024
2b2897e
fixed coding style
pljakobs Oct 31, 2024
cdc6fe6
changed from event->number to number as the loop variable when fillin…
pljakobs Oct 31, 2024
c8059f8
removed redundand ()
pljakobs Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sming/Components/Network/Arch/Esp32/Platform/StationImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,8 +420,8 @@ void StationImpl::staticScanCompleted(wifi_event_sta_scan_done_t* event, uint8_t
wifi_ap_record_t ap_info[number];
uint16_t ap_count{0};
memset(ap_info, 0, sizeof(ap_info));
ESP_ERROR_CHECK(esp_wifi_scan_get_ap_records(&number, ap_info));
ESP_ERROR_CHECK(esp_wifi_scan_get_ap_num(&ap_count));
ESP_ERROR_CHECK(esp_wifi_scan_get_ap_records(&number, ap_info));
Copy link
Contributor

@mikee47 mikee47 Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call to esp_wifi_scan_get_ap_num is actually redundant since it's returned from esp_wifi_scan_get_ap_records:

memset(ap_info, 0, sizeof(ap_info));
ESP_ERROR_CHECK(esp_wifi_scan_get_ap_records(&number, ap_info));
// TODO: Handle hidden APs
for(unsigned i = 0; i < number; i++) {
  list.addElement(new BssInfoImpl(&ap_info[i]));
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was wondering about this and under which conditions the number of detected SSIDs and APs are different, especially, when the number of APs would be less than the number of SSIDs, but since this is the code that the ESP_IDF suggests, I thought it was "the right way"
I can drop the esp_wifi_scan_get_ap_num() call and replace ap_count with number where necessary (or actually use a variable that is a bit more descriptive)

// TODO: Handle hidden APs
for(unsigned i = 0; (i < event->number) && (i < ap_count); i++) {
list.addElement(new BssInfoImpl(&ap_info[i]));
Expand Down
Loading