Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EEXIST to common host errors, don't fail when creating directories #2878

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Add EEXIST to common host errors, don't fail when creating directories #2878

merged 1 commit into from
Aug 31, 2024

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Aug 30, 2024 •
edited
Loading

Calling mkdir when a directory exists returns EEXIST error, which we want to map to IFS::Error::Exists.

In makeDirectories call, it's not an error if an intermediate directory exists, otherwise the whole call will fail.

@SmingHub SmingHub deleted a comment from what-the-diff bot Aug 30, 2024
@slaff slaff added this to the 6.0.0 milestone Aug 31, 2024
@slaff slaff merged commit 2d33243 into SmingHub:develop Aug 31, 2024
46 checks passed
@mikee47 mikee47 deleted the fix/host-eexists branch August 31, 2024 12:18
@slaff slaff mentioned this pull request Dec 11, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mikee47 @slaff