Update CI ccache on every push to develop #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If cache hit occurred on primary key then cache save will fail. This can lead to a stale cache pretty quickly. Workaround is to break into discrete restore / delete / steps.
Only attempt to delete cache for develop
|
@slaff Still issues with caching:
I'm working on fixes but not worth delaying release 5.2 for them. |
Don't worry, I'll wait. |
slaff
pushed a commit
that referenced
this pull request
Jul 18, 2024
**Fix CI library caching** #2865 broken library CI because: - ccache initialisation commands never get executed to set ccache directory - library ccache key must have toolchain in it Fixed by removing the ccache commands from script and updating workflow `env` instead. Just requires call to clear stats before building. NB. This leads to a fair bit of duplication in all 3 workflow files. This is the simplest I can come up with for now. **Simplify workflows** Don't need the `Configure environment` step, just add values to `env`. **Use explicit ccache path** In testing was getting failures saving cache due to ccache not found. Use explicit absolute path to ccache directory. **Restrict ccache size** The cache for each job will increase over time to hit 500MB. Over 40 jobs that's 20GB and will cause cache thrashing. Easy fix: ask ccache to evict anything older than 4 hours from ccache. Do this before printing stats so we can see the resulting size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build times are increasing faster than I expected, so it's clear that to be effective the ccache needs to be kept up to date.
This needs to happen automatically so we can forget about it.
Github caching behaviour is to fail the save operation if a hit occurred on primary key.
In other words, a cache entry will never be overwritten (updated).
There is no provision for a cache update as such: actions/cache#342
The workaround is fairly easy though: break into discrete restore/delete/save steps.
Only the cache for the current branch is deleted, using the
--branchoption togh action-cache delete.This prevents pull requests from contributors with repo write access from deleting the main
developcache.This table shows the intended progression of cache updates, starting from an empty cache:
So always save if (event.branch == develop) or no cache hit