Fix IDF tool installation #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Double-typed 'install', and wildcard tool spec. only supported for IDF 5.2 Just provide explicit list of tools for each version
Since we're not attempting a reinstall in CI can just remove entire tree
Select level of cleaning required Rebuild happens in due course, no need for a specific action.
|
I cleaned the appropriate IDF caches before creating this PR so will actually run the install scripts to verify. |
mikee47
commented
Jul 15, 2024
| # Be specific about which tools we want to install for each IDF version | ||
| IDF_TOOL_PACKAGES=$(tr '\n' ' ' < "$SMING_HOME/Arch/Esp32/Tools/idf_tools-${INSTALL_IDF_VER}.lst") | ||
| echo "Install: $IDF_TOOL_PACKAGES" | ||
| python3 "$IDF_PATH/tools/idf_tools.py" --non-interactive install $IDF_TOOL_PACKAGES |
There was a problem hiding this comment.
Codacy persistently complains when variables such as $IDF_TOOL_PACKETS are used without quotes. I'm not clear on the best way to shut it up, but this usage is intended.
There was a problem hiding this comment.
clear on the best way to shut it up, but this usage is intended.
I will do it. Basically you need to click on "Ignore issue" for this file.
|
@mikee47 do you have something else to add to this PR? |
|
@slaff Nope, all done until something else breaks :-) |
|
I've wiped all the caches so this gets a proper run when it's merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes tool installation for IDF < 5.2.
Overlooked that wildcard tool spec. only supported for IDF 5.2 installer.
Fixed by providing explicit list of tools for each version.
Improve cache-clean action
Not very intuitive so added four levels of cleaning:
Removed the
cache-rebuildaction since we can just do a cache clean then manually trigger a rebuild of the develop branch to accomplish a similar thing.Update
clean-tools.pyscriptDidn't clean some tools.