Fix additional warnings #2849
Merged
Fix additional warnings #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saves 750+MB from cache (per image; 2 images).
Although asan/ubsan aren't supported for embedded targets, there do appear to be more extensive compile-time checks which are useful. Just be nice at the end and don't try to link anything.
Of particular note: - switch statements, may fall through: use [[falthrough]] for C++, not sure what to do for C - unused paramter. Happens for some code when debug isn't enabled - apply [[maybe_unused]]. For others remove parameter name, unless it's useful/descriptive
I2Cdev has similar crud but needs far more work. Leave it.
Some are used in debug statements, [[maybe_unused]], others never used Leave those which might mask other issues, such as code which isn't yet implemented
Support scanning logs obtained via github CLI Integrate GH fetch Add Job information Scan warnings
slaff
reviewed
Jul 2, 2024
slaff
added
3.5 - Approved - Waiting for CI results
and removed
3 - Review
3.5 - Approved - Waiting for CI results
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move sanitizers to main build, add BUILD_VARS
Although asan/ubsan aren't supported for embedded targets,
there do appear to be more extensive compile-time checks which are useful.
Just be nice at the end and don't try to link anything.
Remove Windows esp32
distdirectory after installing toolsSaves 750+MB from cache (per image; 2 images).
Build with additional warnings in STRICT, and fix most of them
Switch statements may fall through: use [[falthrough]] for C++.
There isn't yet a standard for C, though
/* fallthrough */comments seem to work for some compilers (not all).Unused parameters. Happens for some code when debug isn't enabled - apply [[maybe_unused]] in C++.
For others remove parameter name (C++ only), unless it's useful/descriptive.
For C there is no standard, so just using
(void)cast statement.Leave those which might mask other issues, such as code which isn't yet implemented.
esp-idf has lots of unused parameter warnings; quench those.
Base class X should be explicitly initialized in the copy constructor
Fix 'type qualifiers ignored on function return type'
Fix use of signed/unsigned types
Remove unused code from
WirelibraryI2Cdevhas similar crud but needs far more work. Leave it.Fix Graphics library bugs
Unused parameter warnings highlighted bugs in
RegionandSolidBrushclasses.Make Region constructor explicit.
muldivMaxValue parameter 1 never used, not required
Update scanlog.py
There are lots of duplicate warnings in logs, so update this tool to de-duplicate and categorise them by source line.
Support scanning logs obtained via github CLI
Integrate GH fetch
Add Job information
Scan warnings, deduplicate and support filtering
Add README