Fix pgm_read_word for 64-bit host builds
#2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santizer caught invalid memory read because `unsigned long` is 64 bits.
We need everything - including pointers - to be 32-bit aligned so this isn't a bug.
mikee47
changed the title
pgm_read_word and suppress sanitizer alignment warningspgm_read_word for 64-bit host builds
mikee47
changed the title
pgm_read_word for 64-bit host buildspgm_read_word for 64-bit host builds
mikee47
changed the title
pgm_read_word for 64-bit host buildspgm_read_word for 64-bit host builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanitizer caught issue with
pgm_read_dwordon 64-bit build, defined asunsigned longinstead ofuint32_t.Suppress sanitizer
alignmentwarnings for some FlashString methods where (64-bit) pointers are aligned to 32-bit boundaries. We need everything (including pointers) to be 32-bit aligned so this isn't a bug. (It's an optimisation thing.)