-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation fixes #2841
Documentation fixes #2841
Conversation
@slaff Maybe leave this one open for general documentation fixes until we're ready for release? |
805cf0e
to
1735af7
Compare
Test build for review https://smingdev.readthedocs.io/en/fix-documentation-fixes/ |
c2b1773
to
2035a92
Compare
@mikee47 I am planning to create the new 5.2.0 release at the end of next week. Do you need more time to make all changes that you have planned or this works for you? |
@slaff That'll be fine. I'm aiming to finish this PR today sometime. Also got some rework for CI build caching due shortly. |
9f4d7a9
to
19d8ab7
Compare
@slaff OK so documentation is almost there but still keep finding stuff. If I find anything which needs a bit of research I'll add it as a TODO but otherwise it's fixing errors, inconsistencies and duplication. |
@mikee47 thank you for your hard work. This release is going to have the best, for now, documentation and code improvements. Mainly thanks to you :) |
It surprises me how much I (didn't) know: clang, llvm, lldb, macos, timezones, ccache, CI caching/artifacts,.... I've learned a load in the past while! |
Lets keep it for this release, and announce that choco is deprecated. We will remove it for release v.6.0
Old guys like me are still using it :) I will look at the documentation but the last time it was still ok and Eclipse hasn't changed much in the last years. |
Spoke too soon... Forgotten what a PITA Windows was. Path lengths, etc, etc, etc. Also having attempted a scripted winget installation the experience is much better with choco, so thankfully we can stick with that. To recap, at present choco.sming does this, in order:
The item *** is out of date now so I'm thinking we remove that and update python to include 3.12. We could go further actually, reducing choco.sming only to this:
i.e. just a bare bootstrap. Everything else can go in the install script. I'll have a play. |
932361e
to
3ca5324
Compare
3ca5324
to
ea7250a
Compare
Put everything into Host/README, arch/host/index is just a landing page. Clarify availability of ARCH_xx and SOC_xx macros.
Remove lots of duplication Put debugging guides in separate section, page in top menu Put tools and debugging pages immediately after getting-started Put eclipse debugging for all architectures on single page Page in `information` not required
Don't touch license files.
Breathe can't handle `Delegate< ReturnType(ParamTypes...) >`
ea7250a
to
9128050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Noticed only one small typo.
docs/source/about.rst
Outdated
Sming is compatible with (most) standard `Arduino libraries <https://sming.readthedocs.io/en/latest/libraries.html>`_, | ||
which means that you can use any popular hardware in few lines of code. | ||
Sming is provided with a curated set of :doc:`/libraries`, including many standard Arduino-style ones. | ||
Lost of popular hardware can be used in a few lines of code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess "Lost of popular" should be "Lots of popular"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eeek. Can't believe I wrote that! Many popular...
:-)
General review and update to documentation
Smart quotes
These are the 'pretty' versions of regular quotes which can infect code and documentation due to a 'smart quote' virus embedded into many modern editors.
Their purpose is to make documentation (e.g. web pages) look pretty. That's it.
Their presence in C/C++ code is a syntax errror. In documentation, not so much.
However, if they appear in quoted code snippets then these won't work when pasted.
I think it best therefore to avoid them completely, so have all been converted to standard 'dumb' quotes.
Note that Sphinx will automatically convert regular quotes into their curly equivalents so there is no need whatsoever to have these in the source.
TODO (please comment if you have any thoughts on these!):
export.cmd
and documenting. We then don't need the custom sming choco scripts: we should remove those from documentation. Bit more than that: separate PR.