Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #2841

Merged
merged 32 commits into from
Jul 16, 2024
Merged

Documentation fixes #2841

merged 32 commits into from
Jul 16, 2024

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Jun 25, 2024

General review and update to documentation

Smart quotes

These are the 'pretty' versions of regular quotes which can infect code and documentation due to a 'smart quote' virus embedded into many modern editors.
Their purpose is to make documentation (e.g. web pages) look pretty. That's it.

Their presence in C/C++ code is a syntax errror. In documentation, not so much.
However, if they appear in quoted code snippets then these won't work when pasted.

I think it best therefore to avoid them completely, so have all been converted to standard 'dumb' quotes.

Note that Sphinx will automatically convert regular quotes into their curly equivalents so there is no need whatsoever to have these in the source.

TODO (please comment if you have any thoughts on these!):

  • Is espconn still unsupported by lwip2? Don't know: just add note.
  • Windows .cmd install scripts are quite useable, just needs an export.cmd and documenting. We then don't need the custom sming choco scripts: we should remove those from documentation. Bit more than that: separate PR.
  • Is there a way to check/fix use of smart quotes automatically? Nope. I'll write one.
  • Add notes on debugging in vscode - already there, just not as involved as Eclipse
  • Is eclipse still a good development environment? I always found it slow, complicated and clunky, but maybe that's changed? Is the documentation still correct for current versions?
  • Lots of duplication in eclipse debugging pages, merge this into single document

@mikee47
Copy link
Contributor Author

mikee47 commented Jun 25, 2024

@slaff Maybe leave this one open for general documentation fixes until we're ready for release?

@slaff slaff marked this pull request as draft June 25, 2024 14:23
@slaff slaff added this to the 5.2.0 milestone Jun 25, 2024
@mikee47 mikee47 force-pushed the fix/documentation-fixes branch from 805cf0e to 1735af7 Compare June 27, 2024 10:10
@mikee47
Copy link
Contributor Author

mikee47 commented Jun 27, 2024

@mikee47 mikee47 force-pushed the fix/documentation-fixes branch 4 times, most recently from c2b1773 to 2035a92 Compare July 8, 2024 05:29
@slaff
Copy link
Contributor

slaff commented Jul 9, 2024

@mikee47 I am planning to create the new 5.2.0 release at the end of next week. Do you need more time to make all changes that you have planned or this works for you?

@mikee47
Copy link
Contributor Author

mikee47 commented Jul 9, 2024

@slaff That'll be fine. I'm aiming to finish this PR today sometime. Also got some rework for CI build caching due shortly.

@mikee47 mikee47 force-pushed the fix/documentation-fixes branch from 9f4d7a9 to 19d8ab7 Compare July 9, 2024 20:38
@mikee47
Copy link
Contributor Author

mikee47 commented Jul 10, 2024

@slaff OK so documentation is almost there but still keep finding stuff. If I find anything which needs a bit of research I'll add it as a TODO but otherwise it's fixing errors, inconsistencies and duplication.

@slaff
Copy link
Contributor

slaff commented Jul 10, 2024

@mikee47 thank you for your hard work. This release is going to have the best, for now, documentation and code improvements. Mainly thanks to you :)

@mikee47
Copy link
Contributor Author

mikee47 commented Jul 10, 2024

It surprises me how much I (didn't) know: clang, llvm, lldb, macos, timezones, ccache, CI caching/artifacts,.... I've learned a load in the past while!

@slaff
Copy link
Contributor

slaff commented Jul 10, 2024

We then don't need the custom sming choco scripts: we should remove those from documentation.

Lets keep it for this release, and announce that choco is deprecated. We will remove it for release v.6.0

Is eclipse still a good development environment? I always found it slow, complicated and clunky, but maybe that's changed? Is the documentation still correct for current versions?

Old guys like me are still using it :) I will look at the documentation but the last time it was still ok and Eclipse hasn't changed much in the last years.

@mikee47
Copy link
Contributor Author

mikee47 commented Jul 10, 2024

We then don't need the custom sming choco scripts: we should remove those from documentation.

Lets keep it for this release, and announce that choco is deprecated. We will remove it for release v.6.0

Spoke too soon... Forgotten what a PITA Windows was. Path lengths, etc, etc, etc. Also having attempted a scripted winget installation the experience is much better with choco, so thankfully we can stick with that.

To recap, at present choco.sming does this, in order:

  • Install git
  • Install python (version 3.9.1 or 3.10)
  • Install cmake
  • Unpack mingw from SmingTools repo. and update system path
  • Install esp8266 toolchain ***
  • Clone sming (master branch)

The item *** is out of date now so I'm thinking we remove that and update python to include 3.12.
The user then runs sming\Tools\install.cmd to install architecture-specific toolchains as required,
none of which requires updating the system path so is much easier to handle.

We could go further actually, reducing choco.sming only to this:

  • Install git
  • Clone sming (master branch)

i.e. just a bare bootstrap. Everything else can go in the install script.

I'll have a play.

@mikee47 mikee47 force-pushed the fix/documentation-fixes branch 4 times, most recently from 932361e to 3ca5324 Compare July 14, 2024 15:02
Sming/Core/SmingLocale.h Outdated Show resolved Hide resolved
@mikee47 mikee47 force-pushed the fix/documentation-fixes branch from 3ca5324 to ea7250a Compare July 15, 2024 21:30
@mikee47 mikee47 force-pushed the fix/documentation-fixes branch from ea7250a to 9128050 Compare July 16, 2024 12:25
@mikee47 mikee47 changed the title [WIP] Documentation fixes Documentation fixes Jul 16, 2024
@mikee47 mikee47 marked this pull request as ready for review July 16, 2024 12:26
@mikee47 mikee47 requested a review from slaff July 16, 2024 12:26
Copy link
Contributor

@slaff slaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Noticed only one small typo.

Sming is compatible with (most) standard `Arduino libraries <https://sming.readthedocs.io/en/latest/libraries.html>`_,
which means that you can use any popular hardware in few lines of code.
Sming is provided with a curated set of :doc:`/libraries`, including many standard Arduino-style ones.
Lost of popular hardware can be used in a few lines of code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess "Lost of popular" should be "Lots of popular"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eeek. Can't believe I wrote that! Many popular... :-)

@slaff slaff merged commit 07f4472 into SmingHub:develop Jul 16, 2024
46 checks passed
@mikee47 mikee47 deleted the fix/documentation-fixes branch July 17, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants