Fix FlashString library problem defining arrays in class declarations #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikee47
changed the title
- Fix `static_assert` failure using `int64_t` for map keys
- Add integration tests to verify before/after behaviour.
- Update documentation
For example, this code produces `__fstr__myIntArray not defined` error:
```
struct MyClass {
DEFINE_FSTR_ARRAY_LOCAL(myIntArray, int, 1, 2, 3, 4, 5)
};
```
The same issue applies to maps and vectors.
mikee47
force-pushed
the
fix/flashstring-in-class
branch
from
ff803a5 to
63bbaf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, this code produces
__fstr__myIntArray not definederror:The same issue applies to maps and vectors.
Also:
static_assertfailure usingint64_tfor map keys