-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to HostEd #2768
Improvements to HostEd #2768
Conversation
Simplifies implementation since usually all callbacks are required `clang-tidy` gave potential memory leak indication because of Delegates. Not sure if that's real but this fixes it. Reduces memory usage; class delegates use heap.
e206f6a
to
c733819
Compare
Don't need `host_init`, just wrap `init`
c733819
to
97e6bda
Compare
@mikee47 I am trying to compile the Basic_Blink using the command below and I get compilation error?!
The error is:
Any idea how to work around this issue? |
I'm going to guess your version of GCC is old; I'm with Fedora on GCC 13.2.1 - what version are you using? |
Gcc version 9.4.0. I will check if I can upgrade on my Ubuntu 20.04 LTS ... |
Gcc version 10.5.0 is the latest GCC that I can use ... Hm.. have to think about OS upgrade ... |
That should be fine #2758 You can just comment out that assert - I put it there deliberately so we'd know about this sort of thing! |
@slaff You'll doubtless have run into the other issue attempting to build |
This PR proposes some changes to the Hosted classes
Update simpleRPC to master
With clang-tidy #2648 some failures occur in the
simpleRPC
library. Updating this to current master solves the issues.I've also put all the code into the
simpleRPC
namespace which sorts out the conflict withVector
but makes it available for use if required.Tidy HostTests module
Also decode the anonymous 'packet' blob so we can see what's in it and compare with spec. should we wish to update it.
Use abstract base class for callbacks
Simplifies implementation since usually all callbacks are required.
Compiler ensures all methods have implementations.
clang-tidy
gave potential memory leak indication because of Delegates. Not sure if that's real but this fixes it.