Fix valgrind allocator mismatch warnings #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use malloc/free` instead of new/delete, as for MemoryDataStream. Resolves issue with mismatch highlighted by valgrind using `moveString`. Also add null check in allocation.
mikee47
force-pushed
the
fix/sharedmemorystream
branch
2 times, most recently
from
8961492 to
208752e
Compare
mikee47
force-pushed
the
fix/sharedmemorystream
branch
from
208752e to
8ed0253
Compare
mikee47
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes warnings flagged by valgrind when running HostTests.
Fix mismatched new/delete issues with SharedMemoryStream
Use correct templated allocation, also simplifies code.
Fix mismatched allocators with
LimitedMemoryStreamUse malloc/free
instead of new/delete, as for MemoryDataStream. Resolves issue with mismatch highlighted by valgrind usingmoveString`.Also add null check in allocation.