Address CI build warnings #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 24, 2024 15:33
- Run test with lower log verbosity - Fix control rendering: Should use their own bounds for positioning, set button font - Fix const parameters - use unique_ptr for getGlyph calls - Use `std::make_unique` and assignment instead of reset() - Avoid printf - Demote `reinterpret_cast` to `static_cast` where appropriate - Apply coding style to samples - Fix compiler warnings
Check introduced with linker (LD, binutils 2.39) from IDF 5.2 onwards This specifically refers to IRAM, which we do actually need to be writeable and executable
mikee47
force-pushed
the
fix/compile-warnings
branch
from
5733d58 to
bcc9a59
Compare
|
@slaff codeql still running on ubuntu-20.04, actions for this and coverity scan, release and spelling-check could be updated. Shall we do that here or in a separate PR? NB. Also readthedocs can be updated. |
@mikee47 I would prefer separate PRs. Thank you for your hard work. |
|
@mikee47 are you ready with this PR? |
|
@slaff Yes, all done thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses warnings which have crept into the CI build logs.
Worst case is probably esp32 with IDF 5.2 (GCC 13.2) producing 350 warnings, now 65.
General fixes
uint8which should beuint8_t.Fix compiler warnings/errors
Replaced a few more instances of printf with streaming operators, simpler and type-safe.
Fixed
Overloaded virtualwarnings.Note: See remaining warnings for NimBLE (submodule) which need attention.
Graphics library fixes
std::make_uniqueand assignment instead of reset()reinterpret_casttostatic_castwhere appropriateDisable esp32 warning about RWX segments
Check introduced with linker (LD, binutils 2.39) from IDF 5.2 onwards
This specifically refers to IRAM, which we do actually need to be writeable and executable.
(IDF link code disables this warning also.)