Provide consistent serial console interface for samples #2739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a consistent mechanism for a basic serial console interface using the
LineBuffer
class.Refactor LineBuffer
Implement LineBufferBase so we take non-trivial methods out of header.
Add
bool
,String
operators,printTo
method&Simplify usage
Add
process
,processKey
methods and update samplesUse LineBuffer for LiveDebug, Basic_Ota and Basic_FlashIP samples.
These new methods are used to simplify application code.
Note that the
CommandProcessing::Handler
class hasn't been updated here,mainly because it requires customisation of EOL handling (setCommandEOL, getCommandEOL).
Presumably this is because of the variation in EOL sequences (CR, LF, CRLF or LFCR combinations).
The LineBuffer
processKey
method doesn't care, it handles all of these.