Fix esp8266 bootloader building and add diagnostic tools #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove from supported SOC list for this version until fix implemented
mikee47
changed the title
mikee47
force-pushed
the
feature/boot-info
branch
2 times, most recently
from
b3530f6 to
edf0808
Compare
mikee47
changed the title
mikee47
force-pushed
the
feature/boot-info
branch
2 times, most recently
from
0670573 to
700c81b
Compare
mikee47
force-pushed
the
feature/boot-info
branch
from
700c81b to
0bf5773
Compare
mikee47
changed the title
added 4 commits
March 17, 2024 08:38
Ensures consistency with selected settings Remove RBOOT_INTEGRATION (simplify)
Version 4.7 has issues with earlier python versions and breaks with IDF 4.4/4.3.
mikee47
force-pushed
the
feature/boot-info
branch
from
0bf5773 to
485ea4e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on an issue discovered in #2727 when attempting to update the esp8266 boot partition from code during a firmware update.
It was discovered that doing this renders the device unbootable because the boot sector header information is incorrect.
This is because the required
SPI_SIZE,SPI_MODEandSPI_FREQvalues were never passed to the rboot makefile when building.When flashing the boot partition normally, these parameters get passed to esptool, which modifies the provided boot image.
I wasn't aware until now that it did this!
Build rboot as variant
The solution to the main problem is to build rboot as a variant - see https://sming.readthedocs.io/en/latest/_inc/Sming/building.html#library-variants.
The location of the bootloader firmware (in
out/Esp8266/debug/firmware/rboot.bin) is unchanged,but is overwritten by the appropriate variant after every build.
This should ensure consistency with selected settings.
Remove RBOOT_INTEGRATION
As we've forked rboot some time ago this isn't necessary, so we can simplify the code a bit.
Update esptool to v4.6.2 (from v4.4)
Version 4.7 has issues with earlier python versions and breaks with IDF 4.4/4.3.
Add
bootinfobuild targetAdds
make bootinfofor esp architectures which shows details of the boot partition,including header fields so we can check it's correct.
Add
esptoolbuild targetMakes for easier access to esptool.