Fix hw_timer1_read() for esp32 #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK >= 5 requies additional call
mikee47
force-pushed
the
fix/esp32-read-timer
branch
from
a64d39a to
96f56aa
Compare
slaff
added
3.5 - Approved - Waiting for CI results
and removed
3.5 - Approved - Waiting for CI results
labels
mikee47
pushed a commit
to mikee47/Sming
that referenced
this pull request
Jan 9, 2024
Re. SmingHub#2701 call to `timer_ll_trigger_soft_capture` only required for IDF 5.2, as while function signature changed in IDF 5.0 it retains previous behaviour.
slaff
pushed a commit
that referenced
this pull request
Jan 10, 2024
Re. #2701 call to `timer_ll_trigger_soft_capture` only required for IDF 5.2, as while function signature changed in IDF 5.0 it retains previous behaviour. Co-authored-by: mikee47 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IDF >= 5.0 reading the timer1 counter value always returns 0. This is because the low-level HAL call
timer_ll_get_counter_valuewas changed and requires a separate call totimer_ll_trigger_soft_capture.Timer1 is used for callbacks (
HardwareTimerclass) and this bug doesn't affect that behaviour since it relies only on the alarm functionality.Correction: applies only to IDF >= 5.2 (see #2703)