Fix warnings flagged by clang build (#2801)

Co-authored-by: mikee47 <[email protected]>

Sming/Components/Network/src/Network/SmtpClient.h

@@ -182,6 +182,8 @@ class SmtpClient : protected TcpClient
 	void sendMailHeaders(MailMessage* mail);
 	bool sendMailBody(MailMessage* mail);
 
+	using TcpClient::connect;
+
 private:
 	Url url;
 	Vector<String> authMethods;

Sming/Components/Storage/src/include/Storage/Partition.h

@@ -76,7 +76,7 @@ struct esp_partition_info_t;
 
 namespace Disk
 {
-class DiskPart;
+struct DiskPart;
 }
 
 /**

Sming/Core/Data/Stream/LimitedWriteStream.h

@@ -26,7 +26,7 @@ class LimitedWriteStream : public StreamWrapper
 	{
 	}
 
-	bool isValid()
+	bool isValid() const override
 	{
 		return writePos <= maxBytes;
 	}

Sming/Libraries/WebCam/src/Camera/FakeCamera.h

@@ -88,7 +88,7 @@ class FakeCamera: public CameraInterface
 	 *
 	 * @retval bytes successfully read and stored in the buffer
 	 */
-	size_t read(char* buffer, size_t size, size_t offset = 0)
+	size_t read(char* buffer, size_t size, size_t offset = 0) override
 	{
 		// get the current picture and read the desired data from it.
 		file.seekFrom(offset, SeekOrigin::Start);

samples/Basic_ProgMem/app/TestProgmem.cpp

@@ -167,50 +167,54 @@ void testSpeed(Print& out)
 
 	out.printf("Speed tests, %u iterations, times in microseconds\n", iterations);
 	ElapseTimer timer;
-	unsigned tmp = 0;
 	uint32_t baseline, elapsed;
 
 	_FPUTS("Baseline test, read string in RAM...");
+	unsigned sum = 0;
 	timer.start();
 	for(unsigned i = 0; i < iterations; ++i) {
-		tmp += sumBuffer(demoText, sizeof(demoText));
+		sum += sumBuffer(demoText, sizeof(demoText));
 	}
 	baseline = timer.elapsedTime();
-	out << "Elapsed: " << baseline << endl;
+	out << "Elapsed: " << baseline << ", sum " << sum << endl;
 
 #define END()                                                                                                          \
 	elapsed = timer.elapsedTime();                                                                                     \
-	out << "Elapsed: " << elapsed << " (baseline + " << elapsed - baseline << ')' << endl;
+	out << "Elapsed: " << elapsed << " (baseline + " << elapsed - baseline << "), sum " << sum << endl;
 
 	_FPUTS("Load PSTR into stack buffer...");
+	sum = 0;
 	timer.start();
 	for(unsigned i = 0; i < iterations; ++i) {
 		LOAD_PSTR(buf, demoPSTR1);
-		tmp += sumBuffer(buf, sizeof(buf));
+		sum += sumBuffer(buf, sizeof(buf));
 	}
 	END()
 
 	_FPUTS("Load PSTR into String...");
+	sum = 0;
 	timer.start();
 	for(unsigned i = 0; i < iterations; ++i) {
 		String s(demoFSTR1.data());
-		tmp += sumBuffer(s.c_str(), s.length() + 1);
+		sum += sumBuffer(s.c_str(), s.length() + 1);
 	}
 	END()
 
 	_FPUTS("Load FlashString into stack buffer...");
+	sum = 0;
 	timer.start();
 	for(unsigned i = 0; i < iterations; ++i) {
 		LOAD_FSTR(buf, demoFSTR1);
-		tmp += sumBuffer(buf, sizeof(buf));
+		sum += sumBuffer(buf, sizeof(buf));
 	}
 	END()
 
 	_FPUTS("Load FlashString into String...");
+	sum = 0;
 	timer.start();
 	for(unsigned i = 0; i < iterations; ++i) {
 		String s(demoFSTR1);
-		tmp += sumBuffer(s.c_str(), s.length() + 1);
+		sum += sumBuffer(s.c_str(), s.length() + 1);
 	}
 	END()
 }

samples/Basic_ProgMem/app/application.cpp

@@ -16,7 +16,6 @@ const uint8_t demoRam[] = {1, 2, 3, 4, 5};
 const PROGMEM uint8_t demoPgm[] = {1, 2, 3, 4, 5};
 
 const PROGMEM char demoString[] = "Demo";
-const PROGMEM char demoString2[] = "Demo";
 const PROGMEM char demoFormat[] = "Demo %d";
 
 const PROGMEM uint8_t bytes[] = {1, 2, 3, 4, 5, 6, 7, 8};

samples/Basic_Ssl/include/CounterStream.h

@@ -9,7 +9,7 @@
 class CounterStream : public ReadWriteStream
 {
 public:
-	size_t write(const uint8_t* buffer, size_t size)
+	size_t write(const uint8_t* buffer, size_t size) override
 	{
 		streamSize += size;
 		return size;

samples/Basic_Utility/app/utility.cpp

@@ -6,10 +6,6 @@ auto& output = Host::standardOutput;
 
 namespace
 {
-#define XX(name, ext, mime) ext "\0"
-DEFINE_FSTR_LOCAL(fstr_ext, "htm\0" MIME_TYPE_MAP(XX))
-#undef XX
-
 namespace Command
 {
 DEFINE_FSTR(testWebConstants, "testWebConstants")

samples/HttpServer_ConfigNetwork/app/application.cpp

@@ -27,8 +27,10 @@ DEFINE_FSTR(DEFAULT_GATEWAY, "192.168.1.1")
 // Instead of using a SPIFFS file, here we demonstrate usage of imported Flash Strings
 IMPORT_FSTR_LOCAL(flashSettings, PROJECT_DIR "/web/build/settings.html")
 
+#ifdef ENABLE_SSL
 IMPORT_FSTR_LOCAL(serverKey, PROJECT_DIR "/cert/key_1024");
 IMPORT_FSTR_LOCAL(serverCert, PROJECT_DIR "/cert/x509_1024.cer");
+#endif
 
 void onIndex(HttpRequest& request, HttpResponse& response)
 {

samples/Humidity_AM2321/app/application.cpp

@@ -6,7 +6,6 @@ namespace
 AM2321 am2321;
 
 SimpleTimer procTimer;
-bool state = true;
 
 // You can change I2C pins here:
 const int SCL = 5;

samples/LiveDebug/app/application.cpp

@@ -398,7 +398,7 @@ COMMAND_HANDLER(read0)
 					  "At GDB prompt, enter `set $pc = $pc + 3` to skip offending instruction,\r\n"
 					  "then enter `c` to continue"));
 	Serial.flush();
-	uint8_t value = *(uint8_t*)0;
+	uint8_t value = *(volatile uint8_t*)0;
 	Serial << _F("Value at address 0 = 0x") << String(value, HEX, 2) << endl;
 	return true;
 }
@@ -409,7 +409,7 @@ COMMAND_HANDLER(write0)
 					  "At GDB prompt, enter `set $pc = $pc + 3` to skip offending instruction,\r\n"
 					  "then enter `c` to continue"));
 	Serial.flush();
-	*(uint8_t*)0 = 0;
+	*(volatile uint8_t*)0 = 0;
 	Serial.println(_F("...still running!"));
 	return true;
 }

samples/MeteoControl/app/webserver.cpp

@@ -8,8 +8,7 @@ namespace
 {
 HttpServer server;
 HttpClient downloadClient;
-bool serverStarted = false;
-int dowfid = 0;
+bool serverStarted;
 
 void onIndex(HttpRequest& request, HttpResponse& response)
 {

samples/MqttClient_Hello/app/application.cpp

@@ -9,17 +9,13 @@
 
 namespace
 {
-// For testing purposes, try a few different URL formats
-DEFINE_FSTR(MQTT_URL1, "mqtt://test.mosquitto.org:1883")
-DEFINE_FSTR(MQTT_URL2, "mqtts://test.mosquitto.org:8883") // (Need ENABLE_SSL)
-DEFINE_FSTR(MQTT_URL3, "mqtt://frank:[email protected]:1883")
-
 #ifdef ENABLE_SSL
 #include <ssl/private_key.h>
 #include <ssl/cert.h>
-#define MQTT_URL MQTT_URL2
+DEFINE_FSTR(MQTT_URL, "mqtts://test.mosquitto.org:8883")
 #else
-#define MQTT_URL MQTT_URL1
+DEFINE_FSTR(MQTT_URL, "mqtt://test.mosquitto.org:1883")
+// DEFINE_FSTR(MQTT_URL, "mqtt://frank:[email protected]:1883")
 #endif
 
 // Forward declarations