catch situations where mqttClient::connect is called with an empty cl…

…ientName that would otherwise lead to a failing malloc
SmingHub · Oct 25, 2024 · 50547d4 · 50547d4
1 parent 2c08c85
commit 50547d4
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/Sming/Components/Network/src/Network/Mqtt/MqttClient.cpp b/Sming/Components/Network/src/Network/Mqtt/MqttClient.cpp
@@ -199,11 +199,17 @@ bool MqttClient::setWill(const String& topic, const String& message, uint8_t fla
 bool MqttClient::connect(const Url& url, const String& clientName)
 {
 	this->url = url;
+
 	bool useSsl{url.Scheme == URI_SCHEME_MQTT_SECURE};
 	if(!useSsl && url.Scheme != URI_SCHEME_MQTT) {
 		debug_e("Only mqtt and mqtts protocols are allowed");
 		return false;
 	}
+  if(clientName==""){
+    debug_e("no client name configured");
+    return false;
+  }
+
 
 	if(getConnectionState() != eTCS_Ready) {
 		close();