Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get markers data from helper #118

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Coosos
Copy link
Contributor

@Coosos Coosos commented Sep 9, 2020

  • Use of a helper to be reused by store delivery module
  • Use magento stdlib datetime instead of Zend_Locale_Format
  • Call once to the getRetailerCollection method

I fixed the PHPMD & PHPCS errors regarding modified files

We must adapt the code to make it compliant 1.x

@Coosos Coosos force-pushed the feature-get-markers-use-helper branch from 22734f1 to 6009adc Compare September 9, 2020 13:48
@Coosos Coosos marked this pull request as ready for review September 9, 2020 14:51
@Coosos Coosos changed the title WIP: Get markers data from helper Get markers data from helper Sep 9, 2020
@fnogatz
Copy link

fnogatz commented Mar 27, 2023

The commit 03500d8, Use stdlib timezone instead of zend format time, is also required to make Smile_StoreLocator working with the most recent version v2.4.6 of Magento, as it deprecated Zend framework (ZF1) components (see Release Notes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants