Pass excluded categories by reference #1963
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a website where loading a category page in the admin is so slow it's practically unusable. Upon investigation it was discovered that this code was taking the vast majority of time. This change reduced page load time from ~9 minutes to ~15 seconds.
Smile\ElasticsuiteVirtualCategory\Model\Rule::getCategorySearchQuery()takes an array of category IDs that have already been processed, and therefore should be excluded next time. It adds any categories that have now been processed to this array to avoid infinite loops/recursion. However, because this parameter was not being passed by reference the additions were being thrown away and the same categories were being processed again the next time this is called.