New Device (Matter Switch) Eltako Matter Bridge #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lelandblue
requested review from
Con-Tejus,
ctowns,
z-michel,
hcarter-775 and
nickolas-deboom
|
Invitation URL: |
Test Results 64 files 402 suites 0s ⏱️ Results for commit ba30d5a. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against ba30d5a |
nickolas-deboom
approved these changes
Dec 2, 2024
ctowns
reviewed
Dec 2, 2024
| @@ -2420,6 +2420,11 @@ matterManufacturer: | |||
| vendorId: 0x138A | |||
| productId: 0x1392 | |||
| deviceProfileName: matter-bridge | |||
| - id: "4932/1054" | |||
| deviceLabel: EUD64NPN-IPM | |||
There was a problem hiding this comment.
Every other matter bridge has the device label "Matter Bridge". I think we should maintain this if possible. The current label EUD64NPN-IPM seems confusing to me, so if the partner is okay with us changing it I would vouch for a name that is more informative.
There was a problem hiding this comment.
I aggree, Ill change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Adding a fingerprint for a Matter Bridge device listed in the DCL with the Matter Device type = 14 (0xe)
Summary of Completed Tests