Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adafruit NXP Precision Support #183

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Adafruit NXP Precision Support #183

wants to merge 10 commits into from

Conversation

Rosdayle
Copy link

@Rosdayle Rosdayle commented Aug 3, 2022

Relying solely on gyro is not recommended due to excess drift (Unsure if this is fixable)

Relying solely on gyro is not recommended due to excess drift (Unsure if this is fixable)
Copy link
Member

@Eirenliel Eirenliel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code doesn't seem properly formatted, please format the code, thanks.

@Rosdayle
Copy link
Author

Rosdayle commented Aug 6, 2022

Clarification on proper formatting?

@TheDevMinerTV
Copy link
Member

I'd prefer if you actually spelled out Adafruit in the sensor and class name.

src/configuration/CalibrationConfig.h Outdated Show resolved Hide resolved
src/sensors/AdafruitNXPsensor.cpp Outdated Show resolved Hide resolved
@Rosdayle
Copy link
Author

Updated formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants