chore: clarify protocol version

SlimeVR · Oct 11, 2024 · 458f6bd · 458f6bd
1 parent dbce4cb
commit 458f6bd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/debug.h b/src/debug.h
@@ -90,7 +90,7 @@
 // Not recommended for production
 #define ENABLE_INSPECTION false
 
-#define FIRMWARE_BUILD_NUMBER 17
+#define PROTOCOL_VERSION 17
 #define FIRMWARE_VERSION "0.4.0"
 
 #endif // SLIMEVR_DEBUG_H_
diff --git a/src/network/connection.cpp b/src/network/connection.cpp
@@ -401,7 +401,7 @@ void Connection::sendTrackerDiscovery() {
 	MUST(sendInt(0));
 	MUST(sendInt(0));
 	MUST(sendInt(0));
-	MUST(sendInt(FIRMWARE_BUILD_NUMBER));
+	MUST(sendInt(PROTOCOL_VERSION));
 	MUST(sendShortString(FIRMWARE_VERSION));
 	// MAC address string
 	MUST(sendBytes(mac, 6));

diff --git a/src/serial/serialcommands.cpp b/src/serial/serialcommands.cpp
@@ -123,11 +123,12 @@ namespace SerialCommands {
 	}
 
     void printState() {
+		// `build` refers to the protocol version, but it hasn't been changed due to a change needed in the testing software
         logger.info(
             "SlimeVR Tracker, board: %d, hardware: %d, build: %d, firmware: %s, address: %s, mac: %s, status: %d, wifi state: %d",
             BOARD,
             HARDWARE_MCU,
-            FIRMWARE_BUILD_NUMBER,
+            PROTOCOL_VERSION,
             FIRMWARE_VERSION,
             WiFiNetwork::getAddress().toString().c_str(),
             WiFi.macAddress().c_str(),
@@ -204,11 +205,12 @@ namespace SerialCommands {
         }
 
         if (parser->equalCmdParam(1, "TEST")) {
+			// `build` refers to the protocol version, but it hasn't been changed due to a change needed in the testing software
             logger.info(
                 "[TEST] Board: %d, hardware: %d, build: %d, firmware: %s, address: %s, mac: %s, status: %d, wifi state: %d",
                 BOARD,
                 HARDWARE_MCU,
-                FIRMWARE_BUILD_NUMBER,
+                PROTOCOL_VERSION,
                 FIRMWARE_VERSION,
                 WiFiNetwork::getAddress().toString().c_str(),
                 WiFi.macAddress().c_str(),