Troves spawn cleanup functions (solution for #209) #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a change where adding a yielding or erroring function to a trove will not block other tasks added to that trove from cleaning up.
See #209 for a further description of this problem.
This example highlights why this change is useful needed:
Previously, the output would block any tasks added after Task #2 from cleaning up until task #2 completes:
With this change, Task #2 does not block the trove from cleaning up, which saves is more intuitive to the library user, and saves on debugging time to understand the conventional rule of why you can't yield on Task #2: