Corrected PID calculation #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects PID calculation to follow PID conventions and terminology. 1) Removes POnE parameter such that Proportional term always acts on the current error between the setpoint and the input. 2) Corrects Derivative term to calculate based on the rate of change of the error as opposed to the difference in process value, providing a predictive damping effect to improve stability and reduce overshoot.
|
This should probably be marked as a major version bump too. Version 2.0.0. Feel free to set that in the |
Sleitnick
requested changes
Feb 6, 2024
Sleitnick
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects PID calculation to follow PID conventions and terminology.
Removes POnE parameter such that Proportional term always acts on the current error between the setpoint and the input.
Corrects Derivative term to calculate based on the rate of change of the error as opposed to the difference in process value, providing a predictive damping effect to improve stability and reduce overshoot.