Skip to content

Commit

Permalink
Fix unreliables
Browse files Browse the repository at this point in the history
  • Loading branch information
Sleitnick committed Nov 30, 2023
1 parent a638ca2 commit 807141c
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

| Module | Dependency | Description |
| -- | -- | -- |
| [Comm](https://sleitnick.github.io/RbxUtil/api/Comm) | `Comm = "sleitnick/[email protected].0"` | Comm library for remote communication |
| [Comm](https://sleitnick.github.io/RbxUtil/api/Comm) | `Comm = "sleitnick/[email protected].1"` | Comm library for remote communication |
| [Component](https://sleitnick.github.io/RbxUtil/api/Component) | `Component = "sleitnick/[email protected]"` | Component class |
| [Concur](https://sleitnick.github.io/RbxUtil/api/Concur) | `Concur = "sleitnick/[email protected]"` | Concurrent task handler |
| [EnumList](https://sleitnick.github.io/RbxUtil/api/EnumList) | `EnumList = "sleitnick/[email protected]"` | Enum List class |
Expand Down
10 changes: 5 additions & 5 deletions modules/comm/Client/ClientComm.lua
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
-- December 20, 2021

local Comm = require(script.Parent)
local Util = require(script.Parent.Parent.Util)
local Types = require(script.Parent.Parent.Types)
local Util = require(script.Parent.Parent.Util)

--[=[
@class ClientComm
Expand Down Expand Up @@ -195,7 +195,7 @@ function ClientComm:BuildObject(inboundMiddleware: Types.ClientMiddleware?, outb
local reFolder = self._instancesFolder:FindFirstChild("RE")
local rpFolder = self._instancesFolder:FindFirstChild("RP")
if rfFolder then
for _, rf in ipairs(rfFolder:GetChildren()) do
for _, rf in rfFolder:GetChildren() do
if not rf:IsA("RemoteFunction") then
continue
end
Expand All @@ -206,15 +206,15 @@ function ClientComm:BuildObject(inboundMiddleware: Types.ClientMiddleware?, outb
end
end
if reFolder then
for _, re in ipairs(reFolder:GetChildren()) do
if not re:IsA("RemoteEvent") then
for _, re in reFolder:GetChildren() do
if (not re:IsA("RemoteEvent")) and (not re:IsA("UnreliableRemoteEvent")) then
continue
end
obj[re.Name] = self:GetSignal(re.Name, inboundMiddleware, outboundMiddleware)
end
end
if rpFolder then
for _, re in ipairs(rpFolder:GetChildren()) do
for _, re in rpFolder:GetChildren() do
if not re:IsA("RemoteEvent") then
continue
end
Expand Down
6 changes: 3 additions & 3 deletions modules/comm/Server/RemoteProperty.lua
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

local Players = game:GetService("Players")

local Util = require(script.Parent.Parent.Util)
local Types = require(script.Parent.Parent.Types)
local RemoteSignal = require(script.Parent.RemoteSignal)
local Types = require(script.Parent.Parent.Types)
local Util = require(script.Parent.Parent.Util)

local None = Util.None

Expand Down Expand Up @@ -58,7 +58,7 @@ function RemoteProperty.new(
outboundMiddleware: Types.ServerMiddleware?
)
local self = setmetatable({}, RemoteProperty)
self._rs = RemoteSignal.new(parent, name, inboundMiddleware, outboundMiddleware)
self._rs = RemoteSignal.new(parent, name, false, inboundMiddleware, outboundMiddleware)
self._value = initialValue
self._perPlayer = {}
self._playerRemoving = Players.PlayerRemoving:Connect(function(player)
Expand Down
2 changes: 1 addition & 1 deletion modules/comm/wally.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "sleitnick/comm"
description = "Comm library for remote communication"
version = "1.0.0"
version = "1.0.1"
license = "MIT"
authors = ["Stephen Leitnick"]
registry = "https://github.com/UpliftGames/wally-index"
Expand Down

0 comments on commit 807141c

Please sign in to comment.