[KOA-6224] Update to Stylelint v15 and Prettier v3 (#293)

* releases are now automated via GitHub releases and GHA, remove excess files

* remove duplicate prettier rule, that comes from extending stylelint-prettier automatically, add example comment above first rule the way we do in eslint-config-skyscanner, disable newly added declaration-block-no-redundant-longhand-properties rule that causes more churn than value

* align tests to new stylelint and prettier setup

* update to packages that support stylelint@15 and prettier@3, remove deprecated packages, add NODE_OPTIONS to support running prettier via node in jest tests while node doesn't support modules by default

CHANGELOG.md

@@ -1,10 +1,11 @@
 # Change Log
 
-All notable changes to this project will be documented in this file.
+_If `@skyscanner/eslint-config-skyscanner` has a major version change then `@skyscanner/stylelint-config-skyscanner` should also have a major version change, as explained in [the docs](./docs/eslint-as-dependency.md)_
 
-The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
+This file remains for historical references, but all new releases are now documented in the package's [Releases page](https://github.com/Skyscanner/eslint-config-skyscanner/releases).
 
-[Unreleased changes](./UNRELEASED.md)
+The format is based on [Keep a Changelog](http://keepachangelog.com/)
+and this project adheres to [Semantic Versioning](http://semver.org/).
 
 # 9.0.0
 

docs/release.md

@@ -4,12 +4,11 @@ This package can be published by members of the Koala team and authorised Skysca
 
 ### Stable release
 
-To do this:
-- Add a title with the new version for changes in the `CHANGELOG.md` and copy the changes to be published from the `UNRELEASED.md` file to the new section.
-- Stage those changes (`git add CHANGELOG.md UNRELEASED.md`).
-- Run `npm version -f major|minor|patch`. This will create a tagged commit changing the version in `package.json`, and the changes in `CHANGELOG.md`.
-- Run `npm publish --registry=https://registry.npmjs.org/`.
-- Run `git push && git push --tags`.
+Stable releases are now automated.
+
+After a pull request is merged an authorised member next publishes a release via the [GitHub Release UI](https://github.com/Skyscanner/eslint-config-skyscanner/releases).
+
+This will generate an email confirmation. Once this has been confirmed the tag and release will be generated.
 
 ### Alpha/Beta release
 

index.js

@@ -27,13 +27,19 @@ module.exports = {
     'stylelint-prettier',
   ],
   rules: {
+    // Declaring singular values of typography attributes (e.g. `font-weight`) is disallowed. Use a Backpack mixin that sets groups of attributes in sync with the overall design system
+    // https://github.com/Skyscanner/stylelint-plugin-backpack/blob/3acae45c28a015bbdd250b447803da1ac2ed31e8/lib/rules/use-typography-styles/index.js
     'backpack/use-typography-styles': [
       true,
       {
         severity: 'warning',
       },
     ],
-    'prettier/prettier': true,
+
+    // This rule is purely about code style and the impact of code churn turning this on outweighs our perceived benefit of enforcing it
+    // https://stylelint.io/user-guide/rules/declaration-block-no-redundant-longhand-properties/
+    'declaration-block-no-redundant-longhand-properties': null,
+
     'selector-max-id': 0,
     'selector-max-type': [
       0,
@@ -67,7 +73,6 @@ module.exports = {
     'property-no-vendor-prefix': true,
     'selector-no-vendor-prefix': true,
     'value-no-vendor-prefix': true,
-    'string-quotes': 'single',
     'font-family-name-quotes': 'always-where-recommended',
     'at-rule-empty-line-before': [
       'always',

index.test.js

@@ -154,7 +154,7 @@ const validCss = `$kebab-case-variable: 3rem;
     display: 'block';
   } @else if $display == 'inline' {
     display: 'inline';
-  } @else {
+  } @else  {
     display: 'inline-block';
   }
 }
@@ -356,12 +356,6 @@ describe('at rules errors', () => {
   it('raised correct rules', () =>
     result.then((data) =>
       expect(data.results[0].warnings).toEqual([
-        expect.objectContaining({
-          rule: 'prettier/prettier',
-        }),
-        expect.objectContaining({
-          rule: 'prettier/prettier',
-        }),
         expect.objectContaining({
           rule: 'scss/at-else-closing-brace-newline-after',
         }),
@@ -375,6 +369,12 @@ describe('at rules errors', () => {
         expect.objectContaining({
           rule: 'scss/at-if-closing-brace-space-after',
         }),
+        expect.objectContaining({
+          rule: 'prettier/prettier',
+        }),
+        expect.objectContaining({
+          rule: 'prettier/prettier',
+        }),
       ]),
     ));
 });
@@ -410,7 +410,7 @@ describe('flags use-typography-styles', () => {
 // only vertical margins are allowed for non-flexible spacing
 const unitsUsageCSS = `.valid-usage {
   margin-top: 20px;
-  margin-top: 10px;
+  margin-top: 10rem;
   margin-bottom: 100px;
   padding: 20px 2rem;
   padding-top: 20px;